Skip to content

Commit b8df297

Browse files
authored
chore: bump min Node.js to v14.17; update deps (#3611)
This bumps the mininum supported Node.js from v14.5 to v14.17; and bumps a number of dependencies. - v14.5 was for AsyncLocalStorage - v14.6 brings a V8 with spport for private methods syntax, FinalizationRegistry (used by pino@8) - v14.8 brings AsyncResource.bind - v14.17 brings AbortController, AbortSignal.reason (used by readable-stream@4, glob@10, etc.) Closes: #2760
1 parent 51f6e5f commit b8df297

File tree

13 files changed

+1407
-791
lines changed

13 files changed

+1407
-791
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ jobs:
135135
- '16'
136136
- '16.0'
137137
- '14'
138-
- '14.0'
138+
- '14.17'
139139
runs-on: ubuntu-latest
140140
steps:
141141
- uses: actions/checkout@v3

CHANGELOG.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ See the <<upgrade-to-v4>> guide.
3838
[float]
3939
===== Breaking changes
4040
41-
* Set the new minimum supported Node.js to version 14.5.0.
41+
* Set the new minimum supported Node.js to version 14.17.0.
4242
Users of earlier Node.js versions can use elastic-apm-node v3.x, which
4343
supports back to Node.js v8.6.
4444

docs/supported-technologies.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Versions of Node.js past their end-of-life date are not supported.
2020

2121
image::./images/node_release_schedule.svg[Node.js release schedule]
2222

23-
APM agent 4.x releases work with Node.js versions 14.5.0 and later.
23+
APM agent 4.x releases work with Node.js versions 14.17.0 and later.
2424
APM agent 3.x maintenance releases work with Node.js versions 8.6 and later.
2525
We will only break support for older Node.js versions with a major version release of the APM agent.
2626

docs/upgrade-to-v4.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ The following is a guide on upgrading your usage of the Elastic APM Node.js agen
1313
[[v4-nodejs]]
1414
==== Node.js versions
1515

16-
Version 4.x of `elastic-apm-node` supports Node.js v14.5.0 and later.
16+
Version 4.x of `elastic-apm-node` supports Node.js v14.17.0 and later.
1717
(The previous 3.x major supported back to Node.js v8.6.0.)
1818

1919

lib/apm-client/http-apm-client/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ function Client(opts) {
140140
// - `null`: the APM server version is unknown, could not be determined
141141
// - a semver.SemVer instance
142142
this._apmServerVersion = this._conf.apmServerVersion
143-
? semver.SemVer(this._conf.apmServerVersion)
143+
? new semver.SemVer(this._conf.apmServerVersion)
144144
: undefined;
145145
if (!this._apmServerVersion) {
146146
this._fetchApmServerVersion();
@@ -1491,7 +1491,7 @@ Client.prototype._fetchApmServerVersion = function () {
14911491
? serverInfo.ok.version
14921492
: serverInfo.version;
14931493
try {
1494-
this._apmServerVersion = semver.SemVer(verStr);
1494+
this._apmServerVersion = new semver.SemVer(verStr);
14951495
} catch (verErr) {
14961496
setVerUnknownAndNotify(
14971497
`could not parse APM Server version "${verStr}": ${verErr.message}`,

0 commit comments

Comments
 (0)