deploymentsize: Fixes a bug in ParseGb() (#183)

Fixes a bug where defining memory size in capital letters failed with
a misleading error.

Author: karencfv

pkg/api/deploymentapi/deploymentsize/sizes.go

@@ -29,8 +29,9 @@ const minsize = 512
 // ParseGb converts the stringified gigabyte size notation to an int32 Megabyte
 // notation. The minimum size allowed is 0.5g Megabytes with 0.5g increments.
 func ParseGb(strSize string) (int32, error) {
+	strSize = strings.ToLower(strSize)
 	re := regexp.MustCompile(`(?m)(.*\w)(g)`)
-	matches := re.FindStringSubmatch(strings.ToLower(strSize))
+	matches := re.FindStringSubmatch(strSize)
 	if len(matches) < 2 {
 		fmt.Println(matches, "length", len(matches))
 		return 0, fmt.Errorf(`failed to convert "%s" to <size><g>`, strSize)

pkg/api/deploymentapi/deploymentsize/sizes_test.go

@@ -42,6 +42,14 @@ func TestParse(t *testing.T) {
 			name: "parses a 8gb (gigabyte notation)",
 			args: args{strSize: "8gb"}, want: 8 * 1024,
 		},
+		{
+			name: "parses a 0.5G (gigabyte notation)",
+			args: args{strSize: "0.5G"}, want: 512,
+		},
+		{
+			name: "parses a 8GB (gigabyte notation)",
+			args: args{strSize: "8GB"}, want: 8 * 1024,
+		},
 		{
 			name: "trying to parse 512m returns a failure",
 			args: args{strSize: "512m"},