Fix pytest 9 error #3152
Merged
Fix pytest 9 error #3152
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| @pytest.fixture(scope="function") | ||
| @pytest_asyncio.fixture(scope="function") |
Contributor
There was a problem hiding this comment.
Not something you introduced, but in the sync side this fixture has a session scope.
Member
Author
There was a problem hiding this comment.
This is intentional, see the comment below:
# Unfortunately the asyncio client needs to be rebuilt every
# test execution due to how pytest-asyncio manages
# event loops (one per test!)
miguelgrinberg
approved these changes
Nov 12, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-3152-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3a15e1bdc523f0a385398c6c9678fcc30386926e
# Push it to GitHub
git push --set-upstream origin backport-3152-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-3152-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3a15e1bdc523f0a385398c6c9678fcc30386926e
# Push it to GitHub
git push --set-upstream origin backport-3152-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin
added a commit
that referenced
this pull request
Nov 13, 2025
* Fix pytest 9 error (#3152) * Fix pytest 9 error * Use explicit pytest_asyncio fixture * Revert "Fix pytest 9 error" This reverts commit 019e747. * Fix lint * Fix lint better * Add back type ignore (cherry picked from commit 3a15e1b) # Conflicts: # test_elasticsearch/test_async/test_server/conftest.py * Add missing import
pquentin
added a commit
that referenced
this pull request
Nov 13, 2025
* Fix pytest 9 error (#3152) * Fix pytest 9 error * Use explicit pytest_asyncio fixture * Revert "Fix pytest 9 error" This reverts commit 019e747. * Fix lint * Fix lint better * Add back type ignore (cherry picked from commit 3a15e1b) # Conflicts: # test_elasticsearch/test_async/test_server/conftest.py * Add missing import
pquentin
added a commit
that referenced
this pull request
Nov 13, 2025
* Fix pytest 9 error * Use explicit pytest_asyncio fixture * Revert "Fix pytest 9 error" This reverts commit 019e747. * Fix lint * Fix lint better * Add back type ignore (cherry picked from commit 3a15e1b) Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.