Skip to content

Fix pytest 9 error #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 12, 2025
Merged

Fix pytest 9 error #3152

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
019e747
Fix pytest 9 error
pquentin Nov 12, 2025
37f4c8d
Use explicit pytest_asyncio fixture
pquentin Nov 12, 2025
c55bf0e
Revert "Fix pytest 9 error"
pquentin Nov 12, 2025
91daaac
Fix lint
pquentin Nov 12, 2025
c1c94ba
Fix lint better
pquentin Nov 12, 2025
c417f25
Add back type ignore
pquentin Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test_elasticsearch/test_async/test_server/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
# specific language governing permissions and limitations
# under the License.

import pytest
import pytest_asyncio
import sniffio

import elasticsearch

from ...utils import CA_CERTS, wipe_cluster


@pytest.fixture(scope="function")
@pytest_asyncio.fixture(scope="function")
Copy link
Contributor

@miguelgrinberg miguelgrinberg Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something you introduced, but in the sync side this fixture has a session scope.

Copy link
Member Author

@pquentin pquentin Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional, see the comment below:

    # Unfortunately the asyncio client needs to be rebuilt every
    # test execution due to how pytest-asyncio manages
    # event loops (one per test!)

async def async_client_factory(elasticsearch_url):
kwargs = {}
if sniffio.current_async_library() == "trio":
Expand All @@ -42,7 +42,7 @@ async def async_client_factory(elasticsearch_url):
await client.close()


@pytest.fixture(scope="function")
@pytest_asyncio.fixture(scope="function")
def async_client(async_client_factory):
try:
yield async_client_factory
Expand Down
Loading