Skip to content

Commit 15b6599

Browse files
authored
Merge branch 'master' into fix/electron-updater-version-check
2 parents c3c98f4 + 0046104 commit 15b6599

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.changeset/fresh-phones-return.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
feat: Allow users to pass a custom electrons headers URL via env var

packages/app-builder-lib/src/util/yarn.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export function getGypEnv(frameworkInfo: DesktopFrameworkInfo, platform: NodeJS.
7272
// https://github.com/nodejs/node-gyp/issues/21
7373
return {
7474
...common,
75-
npm_config_disturl: "https://electronjs.org/headers",
75+
npm_config_disturl: common.npm_config_electron_mirror || "https://electronjs.org/headers",
7676
npm_config_target: frameworkInfo.version,
7777
npm_config_runtime: "electron",
7878
npm_config_devdir: getElectronGypCacheDir(),

test/src/windows/winPackagerTest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ test.ifAll(
7272
},
7373
},
7474
{
75-
signed: true,
75+
signedWin: true,
7676
}
7777
)
7878
)

0 commit comments

Comments
 (0)