Skip to content

Commit 8d6a600

Browse files
authored
fix: docker deploy script runs out of space on single runner (#8788)
1 parent 0aa407c commit 8d6a600

File tree

2 files changed

+12
-30
lines changed

2 files changed

+12
-30
lines changed

.github/workflows/deploy-docker.yml

Lines changed: 11 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -24,42 +24,24 @@ jobs:
2424
name: Build and Push Docker
2525
needs: run-docker-build-and-test
2626
runs-on: ubuntu-latest
27-
27+
strategy:
28+
fail-fast: true
29+
matrix:
30+
nodeMajorVersion: [
31+
14, 16, 18, 20, 22
32+
]
2833
steps:
29-
- name: Download images artifact - node14
30-
uses: actions/download-artifact@v4
31-
with:
32-
name: electron-builder-all-14
33-
path: ${{ runner.temp }}
34-
35-
- name: Download images artifact - node16
36-
uses: actions/download-artifact@v4
37-
with:
38-
name: electron-builder-all-16
39-
path: ${{ runner.temp }}
40-
41-
- name: Download images artifact - node18
42-
uses: actions/download-artifact@v4
43-
with:
44-
name: electron-builder-all-18
45-
path: ${{ runner.temp }}
46-
47-
- name: Download images artifact - node20
48-
uses: actions/download-artifact@v4
49-
with:
50-
name: electron-builder-all-20
51-
path: ${{ runner.temp }}
52-
53-
- name: Download images artifact - node22
34+
- name: Download images artifact - node${{ matrix.nodeMajorVersion }}
5435
uses: actions/download-artifact@v4
5536
with:
56-
name: electron-builder-all-22
37+
name: electron-builder-all-${{ matrix.nodeMajorVersion }}
5738
path: ${{ runner.temp }}
5839

5940
- name: Load all images
60-
run: find ${{ runner.temp }} -type f -name "electron-builder-all-*.tar" -exec docker image load --input "{}" \;
41+
run: docker image load --input ${{ runner.temp }}/electron-builder-all-${{ matrix.nodeMajorVersion }}.tar
6142

62-
- name: Tag LTS images for electron-builder latest/wine/wine-chrome/wine-mono
43+
- name: Tag LTS (${{ env.LATEST_IMAGE_NODE_MAJOR_VERSION }}) images for electron-builder latest/wine/wine-chrome/wine-mono
44+
if: ${{ matrix.nodeMajorVersion == env.LATEST_IMAGE_NODE_MAJOR_VERSION }}
6345
run: |
6446
docker image tag electronuserland/builder:${{ env.LATEST_IMAGE_NODE_MAJOR_VERSION }} electronuserland/builder:latest
6547
docker image tag electronuserland/builder:${{ env.LATEST_IMAGE_NODE_MAJOR_VERSION }}-wine electronuserland/builder:wine

docker/node/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
ARG IMAGE_VERSION=base
22
FROM --platform=linux/x86_64 electronuserland/builder:$IMAGE_VERSION
33

4-
ARG NODE_VERSION=22.13.0
4+
ARG NODE_VERSION
55

66
# this package is used for snapcraft and we should not clear apt list - to avoid apt-get update during snap build
77
RUN curl -L https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz | tar xz -C /usr/local --strip-components=1 && \

0 commit comments

Comments
 (0)