From 3339faf04949314191c1924d07ef2708460c656b Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Mon, 4 Dec 2023 08:04:52 -0800 Subject: [PATCH 1/2] fix: pull `resultOutputPath` from `CustomWindowsSignTaskConfiguration` (fixes: #7910) --- .../src/codeSign/windowsCodeSign.ts | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts b/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts index a115836d3b3..7095735872f 100644 --- a/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts +++ b/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts @@ -56,18 +56,14 @@ export async function sign(options: WindowsSignOptions, packager: WinPackager): let isNest = false for (const hash of hashes) { const taskConfiguration: WindowsSignTaskConfiguration = { ...options, hash, isNest } - await Promise.resolve( - executor( - { - ...taskConfiguration, - computeSignToolArgs: isWin => computeSignToolArgs(taskConfiguration, isWin), - }, - packager - ) - ) + const config: CustomWindowsSignTaskConfiguration = { + ...taskConfiguration, + computeSignToolArgs: isWin => computeSignToolArgs(taskConfiguration, isWin), + } + await Promise.resolve(executor(config, packager)) isNest = true - if (taskConfiguration.resultOutputPath != null) { - await rename(taskConfiguration.resultOutputPath, options.path) + if (config.resultOutputPath != null) { + await rename(config.resultOutputPath, options.path) } } From 133cd09856d4e15d9be0fa336458f6a712248525 Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Mon, 4 Dec 2023 08:05:41 -0800 Subject: [PATCH 2/2] Add changeset --- .changeset/forty-teachers-run.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/forty-teachers-run.md diff --git a/.changeset/forty-teachers-run.md b/.changeset/forty-teachers-run.md new file mode 100644 index 00000000000..b28ff2cc774 --- /dev/null +++ b/.changeset/forty-teachers-run.md @@ -0,0 +1,5 @@ +--- +"app-builder-lib": patch +--- + +fix: pull `resultOutputPath` from `CustomWindowsSignTaskConfiguration` (fixes: #7910)