Skip to content

Commit 11dfd76

Browse files
robintownrobintown
authored
Merge pull request #204 from element-hq/robin/threads-icon
Remove the unread dot from the threads icon
2 parents 0fa30fa + 38e056b commit 11dfd76

File tree

9 files changed

+22
-32
lines changed

9 files changed

+22
-32
lines changed

‎assets/ios/swift/Icons.xcassets/threads.imageset/threads.svg‎

Lines changed: 1 addition & 1 deletion
Loading

‎assets/ios/swift/Icons.xcassets/threadsSolid.imageset/threadsSolid.svg‎

Lines changed: 1 addition & 1 deletion
Loading

‎assets/web/icons/threads-solid.cjs‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,17 @@
11
var _reactJsxRuntime = require("react/jsx-runtime");
22
var React = require("react");
33
function ThreadsSolidIcon(props, ref) {
4-
return /*#__PURE__*/_reactJsxRuntime.jsxs("svg", {
4+
return /*#__PURE__*/_reactJsxRuntime.jsx("svg", {
55
xmlns: "http://www.w3.org/2000/svg",
66
width: "1em",
77
height: "1em",
88
fill: "currentColor",
99
viewBox: "0 0 24 24",
1010
ref: ref,
1111
...props,
12-
children: [/*#__PURE__*/_reactJsxRuntime.jsx("path", {
13-
fillRule: "evenodd",
14-
d: "M15.792 3A4 4 0 0 0 22 7.621V17a2 2 0 0 1-2 2H6l-2.293 2.293c-.63.63-1.707.184-1.707-.707V5a2 2 0 0 1 2-2zM7 12a.97.97 0 0 0-.713.287A.97.97 0 0 0 6 13q0 .425.287.713Q6.575 14 7 14h6a.97.97 0 0 0 .713-.287A.97.97 0 0 0 14 13a.97.97 0 0 0-.287-.713A.97.97 0 0 0 13 12zm0-4a.97.97 0 0 0-.713.287A.97.97 0 0 0 6 9q0 .425.287.713Q6.575 10 7 10h10a.97.97 0 0 0 .713-.287A.97.97 0 0 0 18 9a.97.97 0 0 0-.287-.713A.97.97 0 0 0 17 8z",
15-
clipRule: "evenodd"
16-
}), /*#__PURE__*/_reactJsxRuntime.jsx("path", {
17-
d: "M19.5 2a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5"
18-
})]
12+
children: /*#__PURE__*/_reactJsxRuntime.jsx("path", {
13+
d: "M4 3h16a2 2 0 0 1 2 2v12a2 2 0 0 1-2 2H6l-2.293 2.293c-.63.63-1.707.184-1.707-.707V5a2 2 0 0 1 2-2m3 7h10q.424 0 .712-.287A.97.97 0 0 0 18 9a.97.97 0 0 0-.288-.713A.97.97 0 0 0 17 8H7a.97.97 0 0 0-.713.287A.97.97 0 0 0 6 9q0 .424.287.713Q6.576 10 7 10m0 4h6q.424 0 .713-.287A.97.97 0 0 0 14 13a.97.97 0 0 0-.287-.713A.97.97 0 0 0 13 12H7a.97.97 0 0 0-.713.287A.97.97 0 0 0 6 13q0 .424.287.713Q6.576 14 7 14"
14+
})
1915
});
2016
}
2117
;

‎assets/web/icons/threads-solid.js‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,17 @@
11
import { forwardRef } from "react";
2-
import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
2+
import { jsx as _jsx } from "react/jsx-runtime";
33
function ThreadsSolidIcon(props, ref) {
4-
return /*#__PURE__*/_jsxs("svg", {
4+
return /*#__PURE__*/_jsx("svg", {
55
xmlns: "http://www.w3.org/2000/svg",
66
width: "1em",
77
height: "1em",
88
fill: "currentColor",
99
viewBox: "0 0 24 24",
1010
ref: ref,
1111
...props,
12-
children: [/*#__PURE__*/_jsx("path", {
13-
fillRule: "evenodd",
14-
d: "M15.792 3A4 4 0 0 0 22 7.621V17a2 2 0 0 1-2 2H6l-2.293 2.293c-.63.63-1.707.184-1.707-.707V5a2 2 0 0 1 2-2zM7 12a.97.97 0 0 0-.713.287A.97.97 0 0 0 6 13q0 .425.287.713Q6.575 14 7 14h6a.97.97 0 0 0 .713-.287A.97.97 0 0 0 14 13a.97.97 0 0 0-.287-.713A.97.97 0 0 0 13 12zm0-4a.97.97 0 0 0-.713.287A.97.97 0 0 0 6 9q0 .425.287.713Q6.575 10 7 10h10a.97.97 0 0 0 .713-.287A.97.97 0 0 0 18 9a.97.97 0 0 0-.287-.713A.97.97 0 0 0 17 8z",
15-
clipRule: "evenodd"
16-
}), /*#__PURE__*/_jsx("path", {
17-
d: "M19.5 2a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5"
18-
})]
12+
children: /*#__PURE__*/_jsx("path", {
13+
d: "M4 3h16a2 2 0 0 1 2 2v12a2 2 0 0 1-2 2H6l-2.293 2.293c-.63.63-1.707.184-1.707-.707V5a2 2 0 0 1 2-2m3 7h10q.424 0 .712-.287A.97.97 0 0 0 18 9a.97.97 0 0 0-.288-.713A.97.97 0 0 0 17 8H7a.97.97 0 0 0-.713.287A.97.97 0 0 0 6 9q0 .424.287.713Q6.576 10 7 10m0 4h6q.424 0 .713-.287A.97.97 0 0 0 14 13a.97.97 0 0 0-.287-.713A.97.97 0 0 0 13 12H7a.97.97 0 0 0-.713.287A.97.97 0 0 0 6 13q0 .424.287.713Q6.576 14 7 14"
14+
})
1915
});
2016
}
2117
;

‎assets/web/icons/threads.cjs‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@ function ThreadsIcon(props, ref) {
1010
ref: ref,
1111
...props,
1212
children: [/*#__PURE__*/_reactJsxRuntime.jsx("path", {
13-
d: "M13 14H7a.97.97 0 0 1-.713-.287A.97.97 0 0 1 6 13q0-.424.287-.713A.97.97 0 0 1 7 12h6q.424 0 .713.287.287.288.287.713 0 .424-.287.713A.97.97 0 0 1 13 14m4-4H7a.97.97 0 0 1-.713-.287A.97.97 0 0 1 6 9q0-.424.287-.713A.97.97 0 0 1 7 8h10q.424 0 .712.287Q18 8.576 18 9t-.288.713A.97.97 0 0 1 17 10"
13+
d: "M7 10a.97.97 0 0 1-.713-.287A.97.97 0 0 1 6 9q0-.424.287-.713A.97.97 0 0 1 7 8h10q.424 0 .712.287Q18 8.576 18 9t-.288.713A.97.97 0 0 1 17 10zm0 4a.97.97 0 0 1-.713-.287A.97.97 0 0 1 6 13q0-.424.287-.713A.97.97 0 0 1 7 12h6q.424 0 .713.287.287.288.287.713 0 .424-.287.713A.97.97 0 0 1 13 14z"
1414
}), /*#__PURE__*/_reactJsxRuntime.jsx("path", {
15-
d: "M15.792 3a4 4 0 0 0-.26 2H4v13.172l.586-.586.146-.133A2 2 0 0 1 6 17h14V8.468a4 4 0 0 0 2-.847V17a2 2 0 0 1-2 2H6l-2.293 2.293-.123.105a1 1 0 0 1-1.571-.65L2 20.585V5a2 2 0 0 1 2-2z"
16-
}), /*#__PURE__*/_reactJsxRuntime.jsx("path", {
17-
d: "M19.5 2a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5"
15+
d: "M3.707 21.293c-.63.63-1.707.184-1.707-.707V5a2 2 0 0 1 2-2h16a2 2 0 0 1 2 2v12a2 2 0 0 1-2 2H6zM6 17h14V5H4v13.172l.586-.586A2 2 0 0 1 6 17"
1816
})]
1917
});
2018
}

‎assets/web/icons/threads.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@ function ThreadsIcon(props, ref) {
1010
ref: ref,
1111
...props,
1212
children: [/*#__PURE__*/_jsx("path", {
13-
d: "M13 14H7a.97.97 0 0 1-.713-.287A.97.97 0 0 1 6 13q0-.424.287-.713A.97.97 0 0 1 7 12h6q.424 0 .713.287.287.288.287.713 0 .424-.287.713A.97.97 0 0 1 13 14m4-4H7a.97.97 0 0 1-.713-.287A.97.97 0 0 1 6 9q0-.424.287-.713A.97.97 0 0 1 7 8h10q.424 0 .712.287Q18 8.576 18 9t-.288.713A.97.97 0 0 1 17 10"
13+
d: "M7 10a.97.97 0 0 1-.713-.287A.97.97 0 0 1 6 9q0-.424.287-.713A.97.97 0 0 1 7 8h10q.424 0 .712.287Q18 8.576 18 9t-.288.713A.97.97 0 0 1 17 10zm0 4a.97.97 0 0 1-.713-.287A.97.97 0 0 1 6 13q0-.424.287-.713A.97.97 0 0 1 7 12h6q.424 0 .713.287.287.288.287.713 0 .424-.287.713A.97.97 0 0 1 13 14z"
1414
}), /*#__PURE__*/_jsx("path", {
15-
d: "M15.792 3a4 4 0 0 0-.26 2H4v13.172l.586-.586.146-.133A2 2 0 0 1 6 17h14V8.468a4 4 0 0 0 2-.847V17a2 2 0 0 1-2 2H6l-2.293 2.293-.123.105a1 1 0 0 1-1.571-.65L2 20.585V5a2 2 0 0 1 2-2z"
16-
}), /*#__PURE__*/_jsx("path", {
17-
d: "M19.5 2a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5"
15+
d: "M3.707 21.293c-.63.63-1.707.184-1.707-.707V5a2 2 0 0 1 2-2h16a2 2 0 0 1 2 2v12a2 2 0 0 1-2 2H6zM6 17h14V5H4v13.172l.586-.586A2 2 0 0 1 6 17"
1816
})]
1917
});
2018
}

‎icons/threads-solid.svg‎

Lines changed: 1 addition & 1 deletion
Loading

‎icons/threads.svg‎

Lines changed: 1 addition & 1 deletion
Loading

‎src/syncIcons.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,13 @@ const iconMetadata = z
137137
}))
138138
// As we don't currently perform optical scaling, we only want the 24px
139139
// icons or those which are explicitly indicated in their name to be
140-
// designed for a smaller size. We also don't want placeholders.
140+
// designed for a smaller size. We also don't want placeholders or icons
141+
// with a baked-in unread messages dot.
141142
.filter(
142-
({ name, properties: { Size: size } }) =>
143+
({ name, properties: { Size: size, Unread: unread } }) =>
143144
(size === "24" || name.includes(`${size}x${size}`)) &&
144-
name !== "Icon Placeholder",
145+
name !== "Icon Placeholder" &&
146+
unread !== "True",
145147
);
146148
for (const { componentSetId, name } of components) {
147149
if (!name) {

0 commit comments

Comments
 (0)