Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse action doesn't validate commit hash #68

Open
cassidyjames opened this issue Aug 12, 2021 · 3 comments
Open

Parse action doesn't validate commit hash #68

cassidyjames opened this issue Aug 12, 2021 · 3 comments

Comments

@cassidyjames
Copy link
Contributor

What Happened

An app dev appears to have rewritten a release tag; #66. The parse and build actions happily succeeded even though the listed commit doesn't match the release's commit.

Expected Behavior

The parse action should check the commit of the release and fail if it doesn't match.

@danirabbit
Copy link
Member

It seems like the dev rewrote history a bit and tagged their release to another commit after it was submitted

@cassidyjames
Copy link
Contributor Author

cassidyjames commented Aug 12, 2021

Correct. But further runs of the parse action should have caught that the release tag and commit hash no longer matched, e.g. when merging main into the PR.

@btkostner
Copy link
Contributor

Both the parse and manifest actions do nothing with git. That is handled by https://github.com/elementary/appcenter-reviews/blob/main/.github/workflows/review.yml#L68. We just need some bash-fu to fail if it's not correct here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants