Rename ignore_errors to ignore to stay closer to the database definition

Author: josevalim

integration_test/myxql/upsert_all_test.exs

@@ -19,29 +19,29 @@ defmodule Ecto.Integration.UpsertAllTest do
     assert TestRepo.insert_all(Post, [post], on_conflict: :nothing) == {1, nil}
   end
 
-  test "insert_mode: :ignore_errors" do
+  test "insert_mode: :ignore" do
     post = [title: "first", uuid: "6fa459ea-ee8a-3ca4-894e-db77e160355e"]
     # First insert succeeds - 1 row inserted
     assert TestRepo.insert_all(Post, [post],
              on_conflict: :nothing,
-             insert_mode: :ignore_errors
+             insert_mode: :ignore
            ) == {1, nil}
 
     # Second insert is ignored due to duplicate - 0 rows inserted (INSERT IGNORE behavior)
     assert TestRepo.insert_all(Post, [post],
              on_conflict: :nothing,
-             insert_mode: :ignore_errors
+             insert_mode: :ignore
            ) == {0, nil}
   end
 
-  test "insert_mode: :ignore_errors with mixed records (some conflicts, some new)" do
+  test "insert_mode: :ignore with mixed records (some conflicts, some new)" do
     # Insert an existing post
     existing_uuid = "6fa459ea-ee8a-3ca4-894e-db77e160355e"
     existing_post = [title: "existing", uuid: existing_uuid]
 
     assert TestRepo.insert_all(Post, [existing_post],
              on_conflict: :nothing,
-             insert_mode: :ignore_errors
+             insert_mode: :ignore
            ) == {1, nil}
 
     # Now insert a batch with one duplicate and two new records
@@ -57,7 +57,7 @@ defmodule Ecto.Integration.UpsertAllTest do
     # With INSERT IGNORE, only 2 rows should be inserted (the non-duplicates)
     assert TestRepo.insert_all(Post, posts,
              on_conflict: :nothing,
-             insert_mode: :ignore_errors
+             insert_mode: :ignore
            ) == {2, nil}
 
     # Verify the data - should have 3 posts total (1 existing + 2 new)
@@ -72,15 +72,15 @@ defmodule Ecto.Integration.UpsertAllTest do
     assert TestRepo.exists?(from p in Post, where: p.uuid == ^new_uuid2)
   end
 
-  test "insert_mode: :ignore_errors with all duplicates" do
+  test "insert_mode: :ignore with all duplicates" do
     # Insert initial posts
     uuid1 = "1fa459ea-ee8a-3ca4-894e-db77e160355e"
     uuid2 = "2fa459ea-ee8a-3ca4-894e-db77e160355e"
     initial_posts = [[title: "first", uuid: uuid1], [title: "second", uuid: uuid2]]
 
     assert TestRepo.insert_all(Post, initial_posts,
              on_conflict: :nothing,
-             insert_mode: :ignore_errors
+             insert_mode: :ignore
            ) == {2, nil}
 
     # Try to insert all duplicates
@@ -89,7 +89,7 @@ defmodule Ecto.Integration.UpsertAllTest do
     # All are duplicates, so 0 rows inserted
     assert TestRepo.insert_all(Post, duplicate_posts,
              on_conflict: :nothing,
-             insert_mode: :ignore_errors
+             insert_mode: :ignore
            ) == {0, nil}
 
     # Verify count unchanged
@@ -102,18 +102,21 @@ defmodule Ecto.Integration.UpsertAllTest do
     {1, nil} = TestRepo.insert_all(Post, [post], on_conflict: on_conflict)
 
     assert TestRepo.insert_all(Post, [post], on_conflict: on_conflict) ==
-           {2, nil}
+             {2, nil}
+
     assert TestRepo.all(from p in Post, select: p.title) == ["second"]
   end
 
   test "on conflict query and conflict target" do
     on_conflict = from Post, update: [set: [title: "second"]]
     post = [title: "first", uuid: "6fa459ea-ee8a-3ca4-894e-db77e160355e"]
+
     assert TestRepo.insert_all(Post, [post], on_conflict: on_conflict) ==
-           {1, nil}
+             {1, nil}
 
     assert TestRepo.insert_all(Post, [post], on_conflict: on_conflict) ==
-           {2, nil}
+             {2, nil}
+
     assert TestRepo.all(from p in Post, select: p.title) == ["second"]
   end
 end

lib/ecto/adapters/myxql.ex

@@ -106,10 +106,10 @@ defmodule Ecto.Adapters.MyXQL do
   ### Insert Mode
 
   The `:insert_mode` option controls the type of INSERT statement generated.
-  When set to `:ignore_errors`, the adapter uses MySQL's `INSERT IGNORE`
+  When set to `:ignore`, the adapter uses MySQL's `INSERT IGNORE`
   syntax:
 
-      Repo.insert_all(Post, posts, insert_mode: :ignore_errors)
+      Repo.insert_all(Post, posts, insert_mode: :ignore)
 
   With `INSERT IGNORE`, MySQL silently ignores errors that would normally
   cause the statement to fail, such as duplicate key violations and certain
@@ -126,11 +126,11 @@ defmodule Ecto.Adapters.MyXQL do
   the row was actually inserted or ignored.
 
   If you need accurate row counts (0 when ignored, 1 when inserted) at the expense of error handling,
-  you can combine `on_conflict: :nothing` with [`insert_mode: :ignore_errors`](#module-insert-mode):
+  you can combine `on_conflict: :nothing` with [`insert_mode: :ignore`](#module-insert-mode):
 
       Repo.insert_all(Post, posts,
         on_conflict: :nothing,
-        insert_mode: :ignore_errors)
+        insert_mode: :ignore)
 
   When both options are used together, `INSERT IGNORE` handles the conflict
   resolution and the `ON DUPLICATE KEY UPDATE` clause is omitted.
@@ -147,7 +147,7 @@ defmodule Ecto.Adapters.MyXQL do
   ```elixir
   Repo.insert_all(Post, posts,
     on_conflict: :nothing,
-    insert_mode: :ignore_errors)
+    insert_mode: :ignore)
 
   # SQL: INSERT IGNORE INTO `posts` (`title`, `uuid`) VALUES (?,?)
   ```
@@ -382,9 +382,9 @@ defmodule Ecto.Adapters.MyXQL do
 
     case Ecto.Adapters.SQL.query(adapter_meta, sql, values ++ query_params, opts) do
       {:ok, %{num_rows: 0}} ->
-        # With INSERT IGNORE (insert_mode: :ignore_errors), 0 rows means the row
+        # With INSERT IGNORE (insert_mode: :ignore), 0 rows means the row
         # was ignored due to a conflict, which is expected behavior
-        if opts[:insert_mode] == :ignore_errors do
+        if opts[:insert_mode] == :ignore do
           {:ok, []}
         else
           raise "insert operation failed to insert any row in the database. " <>

lib/ecto/adapters/myxql/connection.ex

@@ -204,8 +204,8 @@ if Code.ensure_loaded?(MyXQL) do
       error!(nil, ":placeholders is not supported by MySQL")
     end
 
-    # INSERT IGNORE when insert_mode: :ignore_errors is passed, independent of on_conflict
-    defp insert_keyword(:ignore_errors) do
+    # INSERT IGNORE when insert_mode: :ignore is passed, independent of on_conflict
+    defp insert_keyword(:ignore) do
       "INSERT IGNORE INTO "
     end
 
@@ -221,10 +221,10 @@ if Code.ensure_loaded?(MyXQL) do
       []
     end
 
-    # When insert_mode: :ignore_errors is used with on_conflict: :nothing,
+    # When insert_mode: :ignore is used with on_conflict: :nothing,
     # INSERT IGNORE already handles conflicts - no ON DUPLICATE KEY UPDATE needed
     defp on_conflict({:nothing, _, []}, [field | _], opts) do
-      if Keyword.get(opts, :insert_mode) == :ignore_errors do
+      if Keyword.get(opts, :insert_mode) == :ignore do
         []
       else
         # Default :nothing without INSERT IGNORE - uses workaround to simulate "do nothing" behavior

test/ecto/adapters/myxql_test.exs

@@ -1500,8 +1500,7 @@ defmodule Ecto.Adapters.MyXQLTest do
                  end
   end
 
-  test "insert with insert_mode: :ignore_errors" do
-    # INSERT IGNORE via insert_mode: :ignore_errors option
+  test "insert with insert_mode: :ignore" do
     query =
       insert(
         nil,
@@ -1510,7 +1509,7 @@ defmodule Ecto.Adapters.MyXQLTest do
         [[:x, :y]],
         {:nothing, [], []},
         [],
-        insert_mode: :ignore_errors
+        insert_mode: :ignore
       )
 
     assert query == ~s{INSERT IGNORE INTO `schema` (`x`,`y`) VALUES (?,?)}