completes update_all/2 API

Author: jazzyb

lib/sqlite_ecto/query.ex

@@ -37,6 +37,18 @@ defmodule Sqlite.Ecto.Query do
   end
 
   def update_all(query, values) do
+    if query.joins != [] do
+      raise ArgumentError, "JOINS are not supported on UPDATE statements by SQLite"
+    end
+
+    sources = create_names(query, :update)
+    {table, _name, _model} = elem(sources, 0)
+
+    fields = Enum.map_join(values, ", ", fn {field, expr} ->
+      "#{quote_id(field)} = #{expr(expr, sources)}"
+    end)
+    where = where(query.wheres, sources)
+    assemble ["UPDATE", quote_id(table), "SET", fields, where]
   end
 
   def delete_all(query) do
@@ -370,15 +382,19 @@ defmodule Sqlite.Ecto.Query do
 
   ## Generic Query Helpers
 
-  defp create_names(%{sources: sources}) do
-    create_names(sources, 0, tuple_size(sources)) |> List.to_tuple()
+  defp create_names(%{sources: sources}, stmt \\ :select) do
+    create_names(sources, 0, tuple_size(sources), stmt) |> List.to_tuple()
   end
-  defp create_names(sources, pos, limit) when pos < limit do
+  defp create_names(sources, pos, limit, stmt) when pos < limit do
     {table, model} = elem(sources, pos)
-    id = String.first(table) <> Integer.to_string(pos)
-    [{table, id, model} | create_names(sources, pos + 1, limit)]
+    if stmt == :select do
+      id = String.first(table) <> Integer.to_string(pos)
+    else
+      id = nil
+    end
+    [{table, id, model} | create_names(sources, pos + 1, limit, stmt)]
   end
-  defp create_names(_, pos, pos), do: []
+  defp create_names(_, pos, pos, _stmt), do: []
 
   defp select(%Ecto.Query.SelectExpr{fields: fields}, distinct, sources) do
     fields = Enum.map_join(fields, ", ", fn (f) ->
@@ -405,7 +421,11 @@ defmodule Sqlite.Ecto.Query do
 
   defp expr({{:., _, [{:&, _, [idx]}, field]}, _, []}, sources) when is_atom(field) do
     {_, name, _} = elem(sources, idx)
-    "#{name}.#{quote_id(field)}"
+    if name do
+      "#{name}.#{quote_id(field)}"
+    else
+      quote_id(field)
+    end
   end
 
   defp expr({:in, _, [left, right]}, sources) when is_list(right) do

test/sqlite_ecto_test.exs

@@ -504,4 +504,40 @@ defmodule Sqlite.Ecto.Test do
     assert SQL.all(query) ==
            "SELECT m0.\"id\", m2.\"id\" FROM \"model\" AS m0 INNER JOIN \"model2\" AS m1 ON TRUE INNER JOIN \"model2\" AS m2 ON TRUE"
   end
+
+  test "update all" do
+    query = Model |> Queryable.to_query |> normalize
+    assert SQL.update_all(query, [x: 0]) == ~s{UPDATE "model" SET "x" = 0}
+
+    query = from(e in Model, where: e.x == 123) |> normalize
+    assert SQL.update_all(query, [x: 0]) == ~s{UPDATE "model" SET "x" = 0 WHERE ( "x" = 123 )}
+
+    query = Model |> Queryable.to_query |> normalize
+    assert SQL.update_all(query, [x: 0, y: "123"]) == ~s{UPDATE "model" SET "x" = 0, "y" = '123'}
+
+    query = Model |> Queryable.to_query |> normalize
+    assert SQL.update_all(query, [x: quote(do: ^0)]) == ~s{UPDATE "model" SET "x" = ?}
+
+    assert_raise ArgumentError, "JOINS are not supported on UPDATE statements by SQLite", fn ->
+      query = Model |> join(:inner, [p], q in Model2, p.x == q.z) |> normalize
+      assert SQL.update_all(query, [x: 0])
+    end
+  end
+
+#  test "delete all" do
+#    query = Model |> Queryable.to_query |> normalize
+#    assert SQL.delete_all(query) == ~s{DELETE FROM "model" AS m0}
+#
+#    query = from(e in Model, where: e.x == 123) |> normalize
+#    assert SQL.delete_all(query) ==
+#           ~s{DELETE FROM "model" AS m0 WHERE (m0."x" = 123)}
+#
+#    query = Model |> join(:inner, [p], q in Model2, p.x == q.z) |> normalize
+#    assert SQL.delete_all(query) ==
+#           ~s{DELETE FROM "model" AS m0 USING "model2" AS m1 WHERE m0."x" = m1."z"}
+#
+#    query = from(e in Model, where: e.x == 123, join: q in Model2, on: e.x == q.z) |> normalize
+#    assert SQL.delete_all(query) ==
+#           ~s{DELETE FROM "model" AS m0 USING "model2" AS m1 WHERE m0."x" = m1."z" AND (m0."x" = 123)}
+#  end
 end