Skip to content

Commit 8b0af9e

Browse files
authored
Improve UX of Configuration (#120)
1 parent 2fb532b commit 8b0af9e

File tree

18 files changed

+1094
-701
lines changed

18 files changed

+1094
-701
lines changed

examples/echo/lib/echo/peer_handler.ex

+1-8
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,7 @@ defmodule Echo.PeerHandler do
1919
%RTPCodecParameters{
2020
payload_type: 96,
2121
mime_type: "video/VP8",
22-
clock_rate: 90_000,
23-
rtcp_fbs: [%ExSDP.Attribute.RTCPFeedback{pt: 96, feedback_type: :nack}]
24-
},
25-
%RTPCodecParameters{
26-
payload_type: 97,
27-
mime_type: "video/rtx",
28-
clock_rate: 90_000,
29-
sdp_fmtp_line: %ExSDP.Attribute.FMTP{pt: 97, apt: 96}
22+
clock_rate: 90_000
3023
}
3124
]
3225

examples/save_to_file/lib/save_to_file/peer_handler.ex

+1-8
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,7 @@ defmodule SaveToFile.PeerHandler do
2525
%RTPCodecParameters{
2626
payload_type: 96,
2727
mime_type: "video/VP8",
28-
clock_rate: 90_000,
29-
rtcp_fbs: [%ExSDP.Attribute.RTCPFeedback{pt: 96, feedback_type: :nack}]
30-
},
31-
%RTPCodecParameters{
32-
payload_type: 97,
33-
mime_type: "video/rtx",
34-
clock_rate: 90_000,
35-
sdp_fmtp_line: %ExSDP.Attribute.FMTP{pt: 97, apt: 96}
28+
clock_rate: 90_000
3629
}
3730
]
3831

examples/send_from_file/lib/send_from_file/peer_handler.ex

+1-8
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,7 @@ defmodule SendFromFile.PeerHandler do
3030
%RTPCodecParameters{
3131
payload_type: 96,
3232
mime_type: "video/VP8",
33-
clock_rate: 90_000,
34-
rtcp_fbs: [%ExSDP.Attribute.RTCPFeedback{pt: 96, feedback_type: :nack}]
35-
},
36-
%RTPCodecParameters{
37-
payload_type: 97,
38-
mime_type: "video/rtx",
39-
clock_rate: 90_000,
40-
sdp_fmtp_line: %ExSDP.Attribute.FMTP{pt: 97, apt: 96}
33+
clock_rate: 90_000
4134
}
4235
]
4336

examples/whip_whep/lib/whip_whep/peer_supervisor.ex

+1-8
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,7 @@ defmodule WhipWhep.PeerSupervisor do
1818
%RTPCodecParameters{
1919
payload_type: 96,
2020
mime_type: "video/H264",
21-
clock_rate: 90_000,
22-
rtcp_fbs: [%ExSDP.Attribute.RTCPFeedback{pt: 96, feedback_type: :nack}]
23-
},
24-
%RTPCodecParameters{
25-
payload_type: 97,
26-
mime_type: "video/rtx",
27-
clock_rate: 90_000,
28-
sdp_fmtp_line: %ExSDP.Attribute.FMTP{pt: 97, apt: 96}
21+
clock_rate: 90_000
2922
}
3023
]
3124

lib/ex_webrtc/media/ogg/page.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ defmodule ExWebRTC.Media.Ogg.Page do
3737
rest: <<>>
3838
]
3939

40-
@spec read(File.io_device()) :: {:ok, t()} | {:error, term()}
40+
@spec read(File.io_device()) :: {:ok, t()} | {:error, term()} | :eof
4141
def read(file) do
4242
with <<@signature, @version, type, granule_pos::little-64, serial_no::little-32,
4343
sequence_no::little-32, _checksum::little-32,

0 commit comments

Comments
 (0)