Merge meilisearch#376

376: For kaminari fixes zero results bug r=brunoocasali a=bendangelo

# Pull Request

## Related issue
Fixes [#<issue_number>](meilisearch#375)

## What does this PR do?
Fixes this error if no results are found (nullobject is made into zero)
```
TypeError:
       no implicit conversion of MeiliSearch::Rails::NullObject into Integer
```

## PR checklist
Please check if your PR fulfills the following requirements:
- [ x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ x] Have you read the contributing guidelines?
- [ x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Ben D'Angelo <[email protected]>
Co-authored-by: ellnix <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>

Author: 4 people

lib/meilisearch/rails/pagination/kaminari.rb

@@ -19,13 +19,16 @@ def initialize(array, options)
 
         def self.create(results, total_hits, options = {})
           offset = ((options[:page] - 1) * options[:per_page])
-          array = new results, limit: options[:per_page], offset: offset, total_count: total_hits
+          total_hits = 0 if total_hits.nil?
+          offset = 0 if offset.nil?
+          limit = 0 if options[:per_page].nil?
+          array = new results, limit: limit, offset: offset, total_count: total_hits
 
           if array.empty? && !results.empty?
             # since Kaminari 0.16.0, you need to pad the results with nil values so it matches the offset param
             # otherwise you'll get an empty array: https://github.com/amatsuda/kaminari/commit/29fdcfa8865f2021f710adaedb41b7a7b081e34d
             results = Array.new(offset) + results
-            array = new results, offset: offset, limit: options[:per_page], total_count: total_hits
+            array = new results, offset: offset, limit: limit, total_count: total_hits
           end
 
           array

spec/pagination/kaminari_spec.rb

@@ -30,6 +30,17 @@
     expect(p2).to contain_exactly(second)
   end
 
+  it "doesn't crash when meilisearch is disabled" do
+    MeiliSearch::Rails.configuration[:active] = false
+
+    expect do
+      Restaurant.search ''
+    end.not_to raise_error
+
+  ensure
+    MeiliSearch::Rails.configuration[:active] = true
+  end
+
   it 'returns number of total results' do
     hits = Restaurant.search ''
     expect(hits.total_count).to eq(2)