Skip to content

Commit 7825fcb

Browse files
authored
Merge pull request #486 from emacs-php/refactor/rename-group-name
Add php-mode group and some variables belong to new group
2 parents 0af8d71 + b368d43 commit 7825fcb

File tree

1 file changed

+36
-15
lines changed

1 file changed

+36
-15
lines changed

php-mode.el

Lines changed: 36 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,21 @@
122122

123123
;; Local variables
124124
;;;###autoload
125-
(defgroup php nil
126-
"Major mode for editing PHP code."
125+
(defgroup php-mode nil
126+
"Language support for PHP."
127127
:tag "PHP"
128-
:prefix "php-"
129128
:group 'languages
129+
:group 'php
130+
:link '(url-link :tag "Official Site" "https://github.com/emacs-php/php-mode")
131+
:link '(url-link :tag "PHP Mode Wiki" "https://github.com/emacs-php/php-mode/wiki"))
132+
133+
;;;###autoload
134+
(defgroup php-mode nil
135+
"Major mode for editing PHP code."
136+
:tag "PHP Mode"
137+
:prefix "php-mode-"
138+
:group 'languages
139+
:group 'php
130140
:link '(url-link :tag "Official Site" "https://github.com/emacs-php/php-mode")
131141
:link '(url-link :tag "PHP Mode Wiki" "https://github.com/emacs-php/php-mode/wiki"))
132142

@@ -135,13 +145,17 @@
135145
"The location of the PHP executable."
136146
:type 'string)
137147

138-
(defcustom php-default-face 'default
148+
(define-obsolete-variable-alias 'php-default-face 'php-mode-default-face "1.20.0")
149+
(defcustom php-mode-default-face 'default
139150
"Default face in `php-mode' buffers."
151+
:group 'php-mode
140152
:type 'face)
141153

142-
(defcustom php-speedbar-config t
154+
(define-obsolete-variable-alias 'php-speedbar-config 'php-mode-speedbar-config "1.20.0")
155+
(defcustom php-mode-speedbar-config t
143156
"When set to true automatically configures Speedbar to observe PHP files.
144157
Ignores php-file patterns option; fixed to expression \"\\.\\(inc\\|php[s345]?\\)\""
158+
:group 'php-mode
145159
:type 'boolean
146160
:set (lambda (sym val)
147161
(set-default sym val)
@@ -152,14 +166,17 @@ Ignores php-file patterns option; fixed to expression \"\\.\\(inc\\|php[s345]?\\
152166
(defcustom php-mode-speedbar-open nil
153167
"Normally `php-mode' starts with the speedbar closed.
154168
Turning this on will open it whenever `php-mode' is loaded."
169+
:group 'php-mode
155170
:type 'boolean
156171
:set (lambda (sym val)
157172
(set-default sym val)
158173
(when val
159-
(speedbar 1))))
174+
(speedbar 1))))
160175

161-
(defcustom php-template-compatibility t
176+
(define-obsolete-variable-alias 'php-template-compatibility 'php-mode-template-compatibility "1.20.0")
177+
(defcustom php-mode-template-compatibility t
162178
"Should detect presence of html tags."
179+
:group 'php-mode
163180
:type 'boolean)
164181

165182
(defsubst php-in-string-p ()
@@ -195,14 +212,18 @@ of constants when set."
195212
'php-mode `((,(php-mode-extra-constants-create-regexp value) 1 'php-constant))))
196213
(set sym value))
197214

198-
(defcustom php-lineup-cascaded-calls nil
215+
(define-obsolete-variable-alias 'php-lineup-cascaded-calls 'php-mode-lineup-cascaded-calls "1.20.0")
216+
(defcustom php-mode-lineup-cascaded-calls nil
199217
"Indent chained method calls to the previous line."
218+
:group 'php-mode
200219
:type 'boolean)
201220

202-
;;;###autoload
203-
(defcustom php-extra-constants '()
221+
222+
(define-obsolete-variable-alias 'php-extra-constants 'php-mode-extra-constants "1.20.0")
223+
(defcustom php-mode-extra-constants '()
204224
"A list of additional strings to treat as PHP constants."
205-
:type 'list
225+
:group 'php-mode
226+
:type '(repeat string)
206227
:set 'php-mode-extra-constants-set)
207228

208229
(defun php-create-regexp-for-method (visibility)
@@ -266,10 +287,11 @@ can be used to match against definitions for that classlike."
266287
"^\\s-*function\\s-+\\(\\(?:\\sw\\|\\s_\\)+\\)\\s-*(" 1))
267288
"Imenu generic expression for PHP Mode. See `imenu-generic-expression'.")
268289

269-
(defcustom php-do-not-use-semantic-imenu t
290+
(define-obsolete-variable-alias 'php-do-not-use-semantic-imenu 'php-mode-do-not-use-semantic-imenu "1.20.0")
291+
(defcustom php-mode-do-not-use-semantic-imenu t
270292
"Customize `imenu-create-index-function' for `php-mode'.
271293
272-
If using `semantic-mode' `imenu-create-index-function' will be
294+
If using function `semantic-mode' `imenu-create-index-function' will be
273295
set to `semantic-create-imenu-index' due to `c-mode' being its
274296
parent. Set this variable to t if you want to use
275297
`imenu-default-create-index-function' even with `semantic-mode'
@@ -1015,7 +1037,7 @@ this ^ lineup"
10151037
(defgroup php-faces nil
10161038
"Faces used in PHP Mode"
10171039
:tag "PHP Faces"
1018-
:group 'php
1040+
:group 'php-mode
10191041
:group 'faces)
10201042

10211043
(defface php-string '((t (:inherit font-lock-string-face)))
@@ -1860,5 +1882,4 @@ The output will appear in the buffer *PHP*."
18601882
t)
18611883

18621884
(provide 'php-mode)
1863-
18641885
;;; php-mode.el ends here

0 commit comments

Comments
 (0)