Skip to content

Commit 78fd7e8

Browse files
author
Eric James Michael Ritz
committed
README: Clarify a few things
1. Shorten the ’Status’ section to further emphasize that PHP Mode is not dead even though I have stepped back to more of a co-maintainer role. This change is motivated by a few comments on a forum where users mistakeningly thought the project was dead and I was no longer accepting patches. 2. Mention that people can link to personal websites as contributors instead of linking to their GitHub page, if they prefer. 3. Explain that patches should only update `php-mode-modified` if they also affect the `php-mode.el` file itself. If they do not change that file then it is not necessary to update the constant.
1 parent d29a90c commit 78fd7e8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ If you are using an older version of Emacs, or if you simply do not wish to use
2727
Status
2828
------
2929

30-
I am currently looking for someone willing to take over as the maintainer of PHP Mode, ideally before the end of 2014. **From this point forward I will only address bug fixes and add features from other developers.** Please read [my short blog post on the matter](http://ericjmritz.name/2014/08/22/emacs-no-more-of-my-own-code-for-php-mode/). **PHP Mode is not dead.** However, I will no longer be contributing my own features because my time is taken up my game development that I am doing. Nonetheless, I still welcome all contributions and will try to review and merge them as best as possible, so please continue to improve the mode all you great Emacs Lisp developers.
30+
**PHP Mode is not dead.** However, I will no longer be contributing my own features because my time is taken up my game development that I am doing. Nonetheless, I still welcome all contributions and will try to review and merge them as best as possible, so please continue to improve the mode all you great Emacs Lisp developers.
3131

3232

3333
Experimental and In-Progress Features
@@ -208,11 +208,11 @@ How to Contribute
208208

209209
All contributions to PHP Mode are welcome. But please try to do the following when sending improvements or bug fixes:
210210

211-
1. Add your name to the list of ‘Contributors’ in this `README.md` file if it is not there already. If you have a GitHub page then please link your name to it, so people can see your other work.
211+
1. Add your name to the list of ‘Contributors’ in this `README.md` file if it is not there already. If you have a GitHub page and/or personal site then please link your name to it, so people can see your other work.
212212

213213
2. If your contribution addresses an issue on the GitHub project page then include a single line like `GitHub-Issue: 16` with the appropriate issue number.
214214

215-
3. Make sure to update the constant `php-mode-modified`.
215+
3. Make sure to update the constant `php-mode-modified` *only if you patch affects `php-mode.el`,* which means this step is unnecessary for patches related to unit tests.
216216

217217
4. However, please do not modify `php-mode-version-number`. I will decide what constitutes a bump in the version number.
218218

0 commit comments

Comments
 (0)