Skip to content

Commit 03af707

Browse files
committed
Support New module imports
1 parent e097014 commit 03af707

File tree

9 files changed

+474
-189
lines changed

9 files changed

+474
-189
lines changed

app/app.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import Ember from 'ember';
1+
import Application from '@ember/application';
22
import Resolver from './resolver';
33
import loadInitializers from 'ember-load-initializers';
44
import config from './config/environment';
55

6-
const App = Ember.Application.extend({
6+
const App = Application.extend({
77
modulePrefix: config.modulePrefix,
88
podModulePrefix: config.podModulePrefix,
99
Resolver

app/router.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import Ember from 'ember';
1+
import EmberRouter from '@ember/routing/router';
22
import config from './config/environment';
33

4-
const Router = Ember.Router.extend({
4+
const Router = EmberRouter.extend({
55
location: config.locationType,
66
rootURL: config.rootURL
77
});

app/services/ember-cli.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import Babel from 'babel-core';
22
import Path from 'path';
33
import HbsPlugin from '../plugins/hbs-plugin';
4+
import NewModulesPlugin from 'babel-plugin-ember-modules-api-polyfill';
45
import blueprints from '../lib/blueprints';
56
import Ember from 'ember';
67
import moment from 'moment';
@@ -11,6 +12,7 @@ const { computed, inject, RSVP, run, $, testing } = Ember;
1112
const twiddleAppName = 'twiddle';
1213
const oldTwiddleAppNames = ['demo-app', 'app'];
1314
const hbsPlugin = new HbsPlugin(Babel);
15+
const newModulesPlugin = new NewModulesPlugin(Babel);
1416

1517
// These files will be included if not present
1618
const boilerPlateJs = [
@@ -447,7 +449,8 @@ export default Ember.Service.extend({
447449
compileJs(code, filePath) {
448450
code = this.fixTwiddleAppNames(code);
449451
let moduleName = this.nameWithModule(filePath);
450-
return Babel.transform(code, babelOpts(moduleName)).code;
452+
let output = Babel.transform(code, babelOpts(moduleName)).code;
453+
return output;
451454
},
452455

453456
/**
@@ -516,7 +519,8 @@ function babelOpts(moduleName) {
516519
loose: true,
517520
noInterop: true
518521
}],
519-
hbsPlugin
522+
hbsPlugin,
523+
newModulesPlugin
520524
]
521525
};
522526
}

ember-cli-build.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,10 @@ module.exports = function(defaults) {
102102
app.import('vendor/bootstrap-dropdown-submenu-fix.css');
103103
app.import('vendor/hint.css');
104104

105+
app.import('node_modules/babel-plugin-ember-modules-api-polyfill/src/index.js', {
106+
using: [{ transformation: 'cjs', as: 'babel-plugin-ember-modules-api-polyfill' }]
107+
});
108+
105109
let loaderTree = funnel(path.dirname(require.resolve('loader.js')), {
106110
files: ['loader.js'],
107111
destDir: '/assets'

package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"author": "Ember Twiddle Contributors",
1818
"license": "MIT",
1919
"devDependencies": {
20+
"babel-plugin-ember-modules-api-polyfill": "^2.3.0",
2021
"babel-preset-es2017": "^6.24.1",
2122
"babel-standalone": "^6.26.0",
2223
"broccoli-asset-rev": "^2.4.5",
@@ -29,11 +30,12 @@
2930
"ember-ajax": "^3.0.0",
3031
"ember-api-actions": "~0.1.8",
3132
"ember-autoresize": "~0.6.1",
32-
"ember-cli": "2.15.1",
33+
"ember-cli": "2.16.2",
3334
"ember-cli-app-version": "^3.0.0",
3435
"ember-cli-babel": "^6.12.0",
3536
"ember-cli-bootstrap-sassy": "~0.5.8",
3637
"ember-cli-build-notifications": "~0.2.0",
38+
"ember-cli-cjs-transform": "gaurav0/ember-cli-cjs-transform#json",
3739
"ember-cli-code-coverage": "~0.3.12 ",
3840
"ember-cli-dependency-checker": "^2.1.0",
3941
"ember-cli-deploy": "^1.0.2",
@@ -71,8 +73,9 @@
7173
"ember-notify": "^5.2.1",
7274
"ember-resolver": "^4.0.0",
7375
"ember-responsive": "^2.0.8",
76+
"ember-rfc176-data": "~0.3.2",
7477
"ember-route-action-helper": "^2.0.6",
75-
"ember-source": "~2.15.0",
78+
"ember-source": "~2.16.0",
7679
"ember-test-helpers": "~0.6.3",
7780
"eslint-plugin-ember": "^5.1.0",
7881
"ivy-codemirror": "^2.1.0",

tests/helpers/destroy-app.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import Ember from 'ember';
1+
import { run } from '@ember/runloop';
22

33
export default function destroyApp(application) {
4-
Ember.run(() => {
4+
run(() => {
55
application.destroy();
66
window.server.shutdown();
77
});

tests/helpers/module-for-acceptance.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import { module } from 'qunit';
2-
import Ember from 'ember';
2+
import { resolve } from 'rsvp';
33
import startApp from '../helpers/start-app';
44
import destroyApp from '../helpers/destroy-app';
55

6-
const { RSVP: { Promise } } = Ember;
7-
86
export default function(name, options = {}) {
97
module(name, {
108
beforeEach() {
@@ -17,7 +15,7 @@ export default function(name, options = {}) {
1715

1816
afterEach() {
1917
let afterEach = options.afterEach && options.afterEach.apply(this, arguments);
20-
return Promise.resolve(afterEach).then(() => destroyApp(this.application));
18+
return resolve(afterEach).then(() => destroyApp(this.application));
2119
}
2220
});
2321
}

tests/helpers/start-app.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
import Ember from 'ember';
21
import Application from '../../app';
32
import config from '../../config/environment';
4-
5-
const { run } = Ember;
6-
const assign = Ember.assign || Ember.merge;
3+
import { run } from '@ember/runloop';
4+
import { assign } from '@ember/polyfills';
75

86
export default function startApp(attrs) {
97
let application;

0 commit comments

Comments
 (0)