Skip to content

Commit 19c6627

Browse files
fix: ensure v is prefix always
1 parent 0ab7ccc commit 19c6627

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: app/helpers/github-link.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ export function githubLink([project, version, file, line], { isEdit = false }) {
55
const isEmberProject = project === 'ember';
66
const majorVersion = parseInt(version.split('.')[0].replace('v', ''), 10);
77

8+
const baseVersion = `v${version.replace(/^v/, '')}`;
9+
810
// Check if the project is 'ember' and adjust the tag only if the major version is >= 6 to match the Git tags
911
const adjustedVersion =
10-
isEmberProject && majorVersion >= 6 ? `v${version}-ember-source` : `v${version}`;
12+
isEmberProject && majorVersion >= 6 ? `${baseVersion}-ember-source` : baseVersion;
1113

1214
if (isEdit) {
1315
return `https://github.com/${githubMap[project]}/edit/release${mainDir(
@@ -29,9 +31,7 @@ export function githubLink([project, version, file, line], { isEdit = false }) {
2931
// 'https://github.com/emberjs/data/tree/v4.10.0/packages/packages/store/addon/-private/record-arrays/identifier-array.ts#L118'
3032
const fixedFile = file?.replace('../packages/', '../');
3133

32-
return `https://github.com/${
33-
githubMap[project]
34-
}/tree/${adjustedVersion}${mainDir(
34+
return `https://github.com/${githubMap[project]}/tree/${adjustedVersion}${mainDir(
3535
project,
3636
adjustedVersion
3737
)}${fixedFile}#L${line}`;

0 commit comments

Comments
 (0)