Ember 3.26 (#855)

* Ember 3.26

* Fix lint

* Update ember-try.js

Author: RobbieTheWagner

.eslintignore

@@ -13,6 +13,7 @@
 # misc
 /coverage/
 !.*
+.eslintcache
 
 # ember-try
 /.node_modules.ember-try/

.eslintrc.js

@@ -2,39 +2,44 @@
 
 module.exports = {
   globals: {
-    server: true
+    server: true,
   },
   root: true,
   parser: 'babel-eslint',
   parserOptions: {
     ecmaVersion: 2018,
     sourceType: 'module',
     ecmaFeatures: {
-      legacyDecorators: true
-    }
+      legacyDecorators: true,
+    },
   },
-  plugins: [
-    'ember'
-  ],
+  plugins: ['ember'],
   extends: [
     'eslint:recommended',
-    'plugin:ember/recommended'
+    'plugin:ember/recommended',
+    'plugin:prettier/recommended',
   ],
   env: {
-    browser: true
+    browser: true,
   },
   rules: {
     'no-unused-vars': ['error', { args: 'none' }],
     'no-console': ['error', { allow: ['warn', 'error'] }],
     'ember/no-incorrect-calls-with-inline-anonymous-functions': 'off',
     'ember/require-return-from-computed': 'off',
     'ember/no-jquery': 'error',
-    // ember-keyboard uses events
-    'ember/no-on-calls-in-components': 'off',
 
     // TODO: enable these rules
+    'ember/classic-decorator-no-classic-methods': 'off',
+    'ember/no-actions-hash': 'off',
+    'ember/no-classic-classes': 'off',
+    'ember/no-classic-components': 'off',
+    'ember/no-component-lifecycle-hooks': 'off',
+    'ember/no-computed-properties-in-native-classes': 'off',
     'ember/no-get': 'off',
-    'ember/no-private-routing-service': 'off'
+    'ember/no-private-routing-service': 'off',
+    'ember/no-string-prototype-extensions': 'off',
+    'ember/require-tagless-components': 'off',
   },
   overrides: [
     // node files
@@ -51,23 +56,23 @@ module.exports = {
         'config/**/*.js',
         'lib/**/*.js',
         'tests/dummy/config/**/*.js',
-        'tests-node/**/*.js'
+        'tests-node/**/*.js',
       ],
       excludedFiles: [
         'addon/**',
         'addon-test-support/**',
         'app/**',
-        'tests/dummy/app/**'
+        'tests/dummy/app/**',
       ],
       parserOptions: {
-        sourceType: 'script'
+        sourceType: 'script',
       },
       env: {
         browser: false,
-        node: true
+        node: true,
       },
       plugins: ['node'],
-      extends: ['plugin:node/recommended']
+      extends: ['plugin:node/recommended'],
     },
 
     // node test files
@@ -76,12 +81,12 @@ module.exports = {
         describe: true,
         it: true,
         beforeEach: true,
-        afterEach: true
+        afterEach: true,
       },
       files: ['tests-node/**/*.js'],
       rules: {
-        'node/no-unpublished-require': 'off'
-      }
-    }
-  ]
+        'node/no-unpublished-require': 'off',
+      },
+    },
+  ],
 };

.gitignore

@@ -12,6 +12,7 @@
 /.env*
 /.pnp*
 /.sass-cache
+/.eslintcache
 /connect.lock
 /coverage/
 /libpeerconnection.log

.npmignore

@@ -10,10 +10,13 @@
 /.editorconfig
 /.ember-cli
 /.env*
+/.eslintcache
 /.eslintignore
 /.eslintrc.js
 /.git/
 /.gitignore
+/.prettierignore
+/.prettierrc.js
 /.template-lintrc.js
 /.watchmanconfig
 /bower.json

.prettierignore

@@ -0,0 +1,21 @@
+# unconventional js
+/blueprints/*/files/
+/vendor/
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/coverage/
+!.*
+.eslintcache
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try

.prettierrc.js

@@ -2,14 +2,4 @@
 
 module.exports = {
   singleQuote: true,
-  trailingComma: 'none',
-  overrides: [
-    {
-      files: '**/*.hbs',
-      options: {
-        parser: 'glimmer',
-        singleQuote: false
-      }
-    }
-  ]
 };

.template-lintrc.js

@@ -4,11 +4,17 @@ module.exports = {
   extends: 'recommended',
   rules: {
     // TODO: fix these and enable octane
+    'no-action': false,
+    'no-curly-component-invocation': false,
+    'no-duplicate-id': false,
     'no-extra-mut-helper-argument': false,
+    'no-implicit-this': false,
     'no-inline-styles': false,
     'no-invalid-interactive': false,
     'no-negated-condition': false,
     'no-triple-curlies': false,
-    'require-button-type': false
-  }
+    'no-yield-only': false,
+    'require-button-type': false,
+    'require-input-label': false,
+  },
 };

CONTRIBUTING.md

@@ -8,9 +8,8 @@
 
 ## Linting
 
-* `yarn lint:hbs`
-* `yarn lint:js`
-* `yarn lint:js --fix`
+* `yarn lint`
+* `yarn lint:fix`
 
 ## Running tests
 

addon/adapters/-addon-docs.js

@@ -16,9 +16,11 @@ export default Adapter.extend({
 
   findRecord(store, modelClass, id, snapshot) {
     if (modelClass.modelName === 'project') {
-      return fetch(`${this.namespace}/${id}.json`).then((response) => response.json());
+      return fetch(`${this.namespace}/${id}.json`).then((response) =>
+        response.json()
+      );
     } else {
       return store.peekRecord(modelClass.modelName, id);
     }
-  }
+  },
 });

addon/breakpoints.js

@@ -1,5 +1,5 @@
 export default {
-  mobile:  '(max-width: 767px)',
-  tablet:  '(min-width: 768px) and (max-width: 991px)',
-  desktop: '(min-width: 992px) and (max-width: 1200px)'
+  mobile: '(max-width: 767px)',
+  tablet: '(min-width: 768px) and (max-width: 991px)',
+  desktop: '(min-width: 992px) and (max-width: 1200px)',
 };

addon/components/api/x-class/component.js

@@ -2,7 +2,7 @@ import Component from '@ember/component';
 import { computed } from '@ember/object';
 import { or } from '@ember/object/computed';
 import { capitalize } from '@ember/string';
-import { memberFilter }  from '../../../utils/computed';
+import { memberFilter } from '../../../utils/computed';
 import config from 'ember-get-config';
 
 const { showImportPaths } = config['ember-cli-addon-docs'];
@@ -28,22 +28,24 @@ export default Component.extend({
     'component.hasInherited',
     'component.hasProtected',
     'component.hasPrivate',
-    'component.hasDeprecated',
+    'component.hasDeprecated'
   ),
 
   hasContents: computed('class', {
     get() {
       let klass = this.class;
 
-      return klass.get('allFields.length') > 0
-        || klass.get('allAccessors.length') > 0
-        || klass.get('allMethods.length') > 0;
-    }
+      return (
+        klass.get('allFields.length') > 0 ||
+        klass.get('allAccessors.length') > 0 ||
+        klass.get('allMethods.length') > 0
+      );
+    },
   }),
 
   actions: {
     updateFilter(filter, { target: { checked } }) {
       this.set(`show${capitalize(filter)}`, checked);
-    }
-  }
+    },
+  },
 });

addon/components/api/x-component/component.js

@@ -2,7 +2,7 @@ import Component from '@ember/component';
 import { computed } from '@ember/object';
 import { alias, or } from '@ember/object/computed';
 import { capitalize } from '@ember/string';
-import { memberFilter }  from '../../../utils/computed';
+import { memberFilter } from '../../../utils/computed';
 
 import layout from './template';
 
@@ -28,24 +28,26 @@ export default Component.extend({
     'component.hasInternal',
     'component.hasProtected',
     'component.hasPrivate',
-    'component.hasDeprecated',
+    'component.hasDeprecated'
   ),
 
   hasContents: computed('component', {
     get() {
       let component = this.component;
 
-      return component.get('overloadedYields.length') > 0
-        || component.get('arguments.length') > 0
-        || component.get('fields.length') > 0
-        || component.get('accessors.length') > 0
-        || component.get('methods.length') > 0;
-    }
+      return (
+        component.get('overloadedYields.length') > 0 ||
+        component.get('arguments.length') > 0 ||
+        component.get('fields.length') > 0 ||
+        component.get('accessors.length') > 0 ||
+        component.get('methods.length') > 0
+      );
+    },
   }),
 
   actions: {
     updateFilter(filter, { target: { checked } }) {
       this.set(`show${capitalize(filter)}`, checked);
-    }
-  }
+    },
+  },
 });

addon/components/api/x-section/component.js

@@ -22,9 +22,9 @@ export default Component.extend({
    * @function
    * @hide
    */
-  shouldDisplayParams: computed('item.params.[]', function() {
+  shouldDisplayParams: computed('item.params.[]', function () {
     let params = this.get('item.params') || [];
 
-    return params.some(p => p.description || p.name.includes('.'));
+    return params.some((p) => p.description || p.name.includes('.'));
   }),
 });

addon/components/api/x-toggles/component.js

@@ -3,5 +3,5 @@ import layout from './template';
 
 export default Component.extend({
   layout,
-  tagName: ''
+  tagName: '',
 });

addon/components/docs-code-highlight/component.js

@@ -1,5 +1,9 @@
 import classic from 'ember-classic-decorator';
-import { classNameBindings, tagName, layout as templateLayout } from '@ember-decorators/component';
+import {
+  classNameBindings,
+  tagName,
+  layout as templateLayout,
+} from '@ember-decorators/component';
 import Component from '@ember/component';
 import layout from './template';
 import hljs from 'highlight.js/lib/core';

addon/components/docs-demo/component.js

@@ -60,16 +60,15 @@ export default class DocsDemo extends Component {
   get snippets() {
     let activeSnippet = this.activeSnippet;
 
-    return this.snippetRegistrations
-      .map(({ name, label, language }) => {
-        let defaults = this.defaultsFromName(name);
-        return {
-          name,
-          isActive: activeSnippet === name,
-          label: label || defaults.label,
-          language: language || defaults.language
-        };
-      })
+    return this.snippetRegistrations.map(({ name, label, language }) => {
+      let defaults = this.defaultsFromName(name);
+      return {
+        name,
+        isActive: activeSnippet === name,
+        label: label || defaults.label,
+        language: language || defaults.language,
+      };
+    });
   }
 
   /**

addon/components/docs-demo/x-example/component.js

@@ -1,5 +1,8 @@
 import classic from 'ember-classic-decorator';
-import { classNames, layout as templateLayout } from '@ember-decorators/component';
+import {
+  classNames,
+  layout as templateLayout,
+} from '@ember-decorators/component';
 import Component from '@ember/component';
 import layout from './template';
 

addon/components/docs-demo/x-snippet/component.js

@@ -2,17 +2,13 @@ import { scheduleOnce } from '@ember/runloop';
 import Component from '@ember/component';
 
 export default Component.extend({
-  
   init() {
     this._super(...arguments);
 
     scheduleOnce('afterRender', () => {
-      this.get('did-init')(this.getProperties('name', 'label', 'language'))
+      this.get('did-init')(this.getProperties('name', 'label', 'language'));
     });
-  }
-
+  },
 }).reopenClass({
-
-  positionalParams: ['name']
-
+  positionalParams: ['name'],
 });