Skip to content

Commit c5a7501

Browse files
authored
chore(deps): drop ember-href-to (#1006)
Replaces the helper function from this addon with a direct call to the routing service.
1 parent 7ff0b24 commit c5a7501

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

addon/services/docs-routes.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { computed } from '@ember/object';
22
import { A } from '@ember/array';
33
import Service, { inject as service } from '@ember/service';
4-
import { hrefTo } from 'ember-href-to/helpers/href-to';
54
import { assert } from '@ember/debug';
65

76
export default Service.extend({
@@ -29,8 +28,8 @@ export default Service.extend({
2928
}),
3029

3130
routeUrls: computed('routes.[]', function () {
32-
return this.routes.map((route) => {
33-
return hrefTo(this.router, route);
31+
return this.routes.map(([routeName, model]) => {
32+
return this.router.generateURL(routeName, model ? [model] : []);
3433
});
3534
}),
3635

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
"ember-decorators": "^6.1.1",
6767
"ember-fetch": "^8.1.1",
6868
"ember-get-config": "^0.3.0",
69-
"ember-href-to": "^4.0.0",
7069
"ember-keyboard": "^6.0.3",
7170
"ember-modal-dialog": "yapplabs/ember-modal-dialog#76b74f1c4b791fed5b084836c3b1c8c54836ac71",
7271
"ember-responsive": "^4.0.2",

yarn.lock

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5948,9 +5948,10 @@ ember-classy-page-object@rwwagner90/ember-classy-page-object#08d305c1cabdb8ede09
59485948
version "0.6.1"
59495949
resolved "https://codeload.github.com/rwwagner90/ember-classy-page-object/tar.gz/08d305c1cabdb8ede091c4fc7fee86dc4778746d"
59505950
dependencies:
5951-
broccoli-funnel "^2.0.1"
5952-
ember-cli-babel "^7.12.0"
5953-
ember-cli-page-object "^1.17.6"
5951+
broccoli-funnel "^3.0.8"
5952+
ember-cli-babel "^7.21.0"
5953+
ember-cli-htmlbars "^5.2.0"
5954+
ember-cli-page-object "^1.17.7"
59545955

59555956
ember-cli-addon-docs-yuidoc@^1.0.0:
59565957
version "1.0.0"
@@ -6667,13 +6668,6 @@ ember-getowner-polyfill@^2.2.0:
66676668
ember-cli-version-checker "^2.1.0"
66686669
ember-factory-for-polyfill "^1.3.1"
66696670

6670-
ember-href-to@^4.0.0:
6671-
version "4.1.0"
6672-
resolved "https://registry.yarnpkg.com/ember-href-to/-/ember-href-to-4.1.0.tgz#daa8b398bc5a51ba3ba5ff736e099f0a0d010b7b"
6673-
integrity sha512-h8xSzt9lQAUzk4JvXNnZjRj29hOWKo92VIHzH68io13UurDBaMmJ4WtXa0iy/awlSFs6h8BwpEWQeaCYIZDRuQ==
6674-
dependencies:
6675-
ember-cli-babel "^7.13.2"
6676-
66776671
"ember-inflector@^2.0.0 || ^3.0.0 || ^4.0.0", ember-inflector@^4.0.1:
66786672
version "4.0.2"
66796673
resolved "https://registry.yarnpkg.com/ember-inflector/-/ember-inflector-4.0.2.tgz#4494f1a5f61c1aca7702d59d54024cc92211d8ec"

0 commit comments

Comments
 (0)