changes according to feedback

Author: kakoni

embulk-input-oracle/README.md

@@ -149,3 +149,21 @@ in:
 ```
 $ ./gradlew gem
 ```
+
+Running tests:
+You need to add ojdbcj.jar to embulk-input-oracle/driver
+
+Also oracle.yml is needed
+```
+type: oracle
+host: localhost
+port: 1521
+database: xe
+user: system
+password: pass
+```
+
+To run tests for oracle project only
+```
+$ EMBULK_INPUT_ORACLE_TEST_CONFIG=oracle.yml ./gradlew :embulk-input-oracle:check --info
+```

embulk-input-oracle/src/main/java/org/embulk/input/oracle/getter/OracleColumnGetterFactory.java

@@ -6,7 +6,7 @@
 import org.embulk.input.jdbc.JdbcInputConnection;
 import org.embulk.input.jdbc.getter.ColumnGetter;
 import org.embulk.input.jdbc.getter.ColumnGetterFactory;
-import org.embulk.input.jdbc.getter.TimestampWithTimeZoneIncrementalHandler;
+import org.embulk.input.jdbc.getter.TimestampWithoutTimeZoneIncrementalHandler;
 import org.embulk.spi.PageBuilder;
 import org.joda.time.DateTimeZone;
 
@@ -25,9 +25,9 @@ public ColumnGetter newColumnGetter(JdbcInputConnection con, AbstractJdbcInputPl
 
     switch (column.getTypeName()) {
       case "DATE":
-        return new TimestampWithTimeZoneIncrementalHandler(getter);
+        return new TimestampWithoutTimeZoneIncrementalHandler(getter);
       case "TIMESTAMP":
-        return new TimestampWithTimeZoneIncrementalHandler(getter);
+        return new TimestampWithoutTimeZoneIncrementalHandler(getter);
       default:
         return getter;
     }

embulk-input-oracle/src/main/java/org/embulk/input/oracle/getter/OracleTimestampWithTimeZoneIncrementalHandler.java

@@ -1,4 +1,4 @@
 table: load
-last_record: ['2016-11-02T02:00:04.000000Z']
+last_record: ['2016-11-02T04:00:04.000000']
 incremental: true
 incremental_columns: [dt]

embulk-input-oracle/src/test/resources/org/embulk/input/oracle/test/expect/incremental/date/config_2.yml

@@ -1,3 +1,3 @@
 in:
-  last_record: ['2016-11-02T02:00:04.000000Z']
+  last_record: ['2016-11-02T04:00:04.000000']
 out: {}

embulk-input-oracle/src/test/resources/org/embulk/input/oracle/test/expect/incremental/date/expected_1.diff

@@ -1,3 +1,3 @@
 in:
-  last_record: ['2016-11-02T02:00:06.000000Z']
+  last_record: ['2016-11-02T04:00:06.000000']
 out: {}

embulk-input-oracle/src/test/resources/org/embulk/input/oracle/test/expect/incremental/date/expected_2.diff

@@ -1,4 +1,4 @@
 table: load
-last_record: ['2016-11-02T02:00:05.333003Z']
+last_record: ['2016-11-02T04:00:05.333003']
 incremental: true
 incremental_columns: [ts]

embulk-input-oracle/src/test/resources/org/embulk/input/oracle/test/expect/incremental/timestamp/config_2.yml

@@ -1,3 +1,3 @@
 in:
-  last_record: ['2016-11-02T02:00:05.333003Z']
+  last_record: ['2016-11-02T04:00:05.333003']
 out: {}

embulk-input-oracle/src/test/resources/org/embulk/input/oracle/test/expect/incremental/timestamp/expected_1.diff

@@ -1,3 +1,3 @@
 in:
-  last_record: ['2016-11-02T02:00:06.000000Z']
+  last_record: ['2016-11-02T04:00:06.000000']
 out: {}