Add comments for minimum suffix length.

civitaspo · civitaspo · commit 89a63aabee57 · 2021-09-21T21:10:53.000+09:00
diff --git a/embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/AbstractJdbcOutputPlugin.java b/embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/AbstractJdbcOutputPlugin.java
@@ -765,7 +765,10 @@ private void dropTables() throws SQLException
     static int calculateSuffixLength(int taskCount)
     {
         assert(taskCount >= 0);
-        return Math.max(3, String.valueOf(taskCount - 1).length());
+        // NOTE: for backward compatibility
+        //       See. https://github.com/embulk/embulk-output-jdbc/pull/301
+        int minimumLength = 3;
+        return Math.max(minimumLength, String.valueOf(taskCount - 1).length());
     }
 
     protected String generateIntermediateTableNameFormat(String baseTableName, JdbcOutputConnection con,

Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,10 @@ private void dropTables() throws SQLException`
`765`	`765`	`static int calculateSuffixLength(int taskCount)`
`766`	`766`	`{`
`767`	`767`	`assert(taskCount >= 0);`
`768`		`- return Math.max(3, String.valueOf(taskCount - 1).length());`
	`768`	`+ // NOTE: for backward compatibility`
	`769`	`+ // See. https://github.com/embulk/embulk-output-jdbc/pull/301`
	`770`	`+ int minimumLength = 3;`
	`771`	`+ return Math.max(minimumLength, String.valueOf(taskCount - 1).length());`
`769`	`772`	`}`
`770`	`773`
`771`	`774`	`protected String generateIntermediateTableNameFormat(String baseTableName, JdbcOutputConnection con,`