Skip to content

Commit b5dfaee

Browse files
author
Dai MIKURUBE
committed
Replace Exec.getLogger with LoggerFactory.getLogger
1 parent 88c6cc4 commit b5dfaee

File tree

14 files changed

+30
-34
lines changed

14 files changed

+30
-34
lines changed

embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/AbstractJdbcOutputPlugin.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.embulk.spi.util.RetryExecutor;
2626
import org.embulk.spi.util.RetryExecutor.RetryGiveupException;
2727
import org.slf4j.Logger;
28+
import org.slf4j.LoggerFactory;
2829
import org.joda.time.DateTimeZone;
2930

3031
import com.fasterxml.jackson.annotation.JsonCreator;
@@ -66,7 +67,7 @@
6667
public abstract class AbstractJdbcOutputPlugin
6768
implements OutputPlugin
6869
{
69-
protected final Logger logger = Exec.getLogger(getClass());
70+
protected static final Logger logger = LoggerFactory.getLogger(AbstractJdbcOutputPlugin.class);
7071

7172
public interface PluginTask
7273
extends Task
@@ -1273,7 +1274,7 @@ class RetryableSQLExecution implements Retryable<Void> {
12731274
private final String errorMessage;
12741275
private final IdempotentSqlRunnable op;
12751276

1276-
private final Logger logger = Exec.getLogger(this.getClass());
1277+
private final Logger logger = LoggerFactory.getLogger(RetryableSQLExecution.class);
12771278

12781279
public RetryableSQLExecution(IdempotentSqlRunnable op, String errorMessage) {
12791280
this.errorMessage = errorMessage;

embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/JdbcOutputConnection.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,14 @@
1212
import java.util.Locale;
1313

1414
import org.slf4j.Logger;
15+
import org.slf4j.LoggerFactory;
1516

1617
import com.google.common.base.Optional;
1718

18-
import org.embulk.spi.Exec;
19-
2019
public class JdbcOutputConnection
2120
implements AutoCloseable
2221
{
23-
protected final Logger logger = Exec.getLogger(JdbcOutputConnection.class);
22+
protected static final Logger logger = LoggerFactory.getLogger(JdbcOutputConnection.class);
2423
protected final Connection connection;
2524
protected final String schemaName;
2625
protected final DatabaseMetaData databaseMetaData;

embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/JdbcUtils.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
import java.util.regex.Matcher;
66
import java.util.regex.Pattern;
77
import org.slf4j.Logger;
8-
import org.embulk.spi.Exec;
8+
import org.slf4j.LoggerFactory;
99

1010
public class JdbcUtils
1111
{
12-
public final Logger logger = Exec.getLogger(JdbcUtils.class.getName());
12+
public static final Logger logger = LoggerFactory.getLogger(JdbcUtils.class);
1313

1414
private static String[] SEARCH_STRING_SPECIAL_CHARS = new String[] { "_", "%" };
1515

@@ -150,4 +150,3 @@ public int executeUpdateWithSqlLogging(Statement stmt, String sql) throws SQLExc
150150
// // TODO any substitute implementations?
151151
//}
152152
}
153-

embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/StandardBatchInsert.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
import java.sql.Time;
1111
import com.google.common.base.Optional;
1212
import org.slf4j.Logger;
13+
import org.slf4j.LoggerFactory;
1314
import org.embulk.spi.time.Timestamp;
14-
import org.embulk.spi.Exec;
1515

1616
public class StandardBatchInsert
1717
implements BatchInsert
1818
{
19-
private final Logger logger = Exec.getLogger(StandardBatchInsert.class);
19+
private static final Logger logger = LoggerFactory.getLogger(StandardBatchInsert.class);
2020

2121
private final JdbcOutputConnector connector;
2222
private final Optional<MergeConfig> mergeConfig;

embulk-output-mysql/src/main/java/org/embulk/output/MySQLTimeZoneComparison.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
package org.embulk.output;
22

3-
import org.embulk.spi.Exec;
43
import org.slf4j.Logger;
5-
4+
import org.slf4j.LoggerFactory;
65

76
import java.sql.Connection;
87
import java.sql.ResultSet;
@@ -19,7 +18,7 @@ public class MySQLTimeZoneComparison {
1918

2019
private Connection connection;
2120

22-
private final Logger logger = Exec.getLogger(getClass());
21+
private static final Logger logger = LoggerFactory.getLogger(MySQLTimeZoneComparison.class);
2322

2423
public MySQLTimeZoneComparison(Connection connection)
2524
{

embulk-output-oracle/src/main/java/org/embulk/output/oracle/oci/OCIManager.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import java.util.HashMap;
55
import java.util.Map;
66

7-
import org.embulk.spi.Exec;
87
import org.slf4j.Logger;
8+
import org.slf4j.LoggerFactory;
99

1010
public class OCIManager
1111
{
@@ -14,8 +14,7 @@ private static class OCIWrapperAndCounter {
1414
public int counter;
1515
}
1616

17-
18-
private final Logger logger = Exec.getLogger(getClass());
17+
private static final Logger logger = LoggerFactory.getLogger(OCIManager.class);
1918

2019
private Map<Object, OCIWrapperAndCounter> ociAndCounters = new HashMap<Object, OCIWrapperAndCounter>();
2120

embulk-output-oracle/src/main/java/org/embulk/output/oracle/oci/OCIWrapper.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,15 @@
1313
import jnr.ffi.provider.jffi.ByteBufferMemoryIO;
1414

1515
import org.embulk.output.jdbc.AbstractJdbcOutputPlugin;
16-
import org.embulk.spi.Exec;
1716
import org.slf4j.Logger;
18-
17+
import org.slf4j.LoggerFactory;
1918

2019
public class OCIWrapper
2120
{
2221
private static OCI oci;
2322
private static BulkOCI bulkOci;
2423

25-
private final Logger logger = Exec.getLogger(getClass());
24+
private static final Logger logger = LoggerFactory.getLogger(OCIWrapper.class);
2625

2726
private final Charset systemCharset;
2827
private Pointer envHandle;

embulk-output-postgresql/src/main/java/org/embulk/output/postgresql/PostgreSQLCopyBatchInsert.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
import org.embulk.output.jdbc.JdbcOutputConnector;
99
import org.embulk.output.jdbc.JdbcSchema;
1010
import org.embulk.output.jdbc.TableIdentifier;
11-
import org.embulk.spi.Exec;
1211
import org.postgresql.copy.CopyManager;
1312
import org.slf4j.Logger;
13+
import org.slf4j.LoggerFactory;
1414

1515
public class PostgreSQLCopyBatchInsert
1616
extends AbstractPostgreSQLCopyBatchInsert
1717
{
18-
private final Logger logger = Exec.getLogger(PostgreSQLCopyBatchInsert.class);
18+
private static final Logger logger = LoggerFactory.getLogger(PostgreSQLCopyBatchInsert.class);
1919
private final JdbcOutputConnector connector;
2020

2121
private PostgreSQLOutputConnection connection = null;

embulk-output-redshift/src/main/java/org/embulk/output/RedshiftOutputPlugin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
import java.sql.SQLException;
66

77
import org.slf4j.Logger;
8+
import org.slf4j.LoggerFactory;
89
import com.google.common.base.Optional;
910
import com.google.common.collect.ImmutableSet;
1011
import com.amazonaws.auth.AWSCredentialsProvider;
11-
import org.embulk.spi.Exec;
1212
import org.embulk.util.aws.credentials.AwsCredentials;
1313
import org.embulk.util.aws.credentials.AwsCredentialsTaskWithPrefix;
1414
import org.embulk.config.Config;
@@ -26,7 +26,7 @@
2626
public class RedshiftOutputPlugin
2727
extends AbstractJdbcOutputPlugin
2828
{
29-
private final Logger logger = Exec.getLogger(RedshiftOutputPlugin.class);
29+
private static final Logger logger = LoggerFactory.getLogger(RedshiftOutputPlugin.class);
3030

3131
public interface RedshiftPluginTask extends AwsCredentialsTaskWithPrefix, PluginTask
3232
{

embulk-output-redshift/src/main/java/org/embulk/output/redshift/RedshiftCopyBatchInsert.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
import org.embulk.output.jdbc.JdbcSchema;
2222
import org.embulk.output.jdbc.TableIdentifier;
2323
import org.embulk.output.postgresql.AbstractPostgreSQLCopyBatchInsert;
24-
import org.embulk.spi.Exec;
2524
import org.slf4j.Logger;
25+
import org.slf4j.LoggerFactory;
2626

2727
import com.amazonaws.AmazonClientException;
2828
import com.amazonaws.auth.AWSCredentialsProvider;
@@ -44,7 +44,7 @@
4444
public class RedshiftCopyBatchInsert
4545
extends AbstractPostgreSQLCopyBatchInsert
4646
{
47-
private final Logger logger = Exec.getLogger(RedshiftCopyBatchInsert.class);
47+
private static final Logger logger = LoggerFactory.getLogger(RedshiftCopyBatchInsert.class);
4848
private final JdbcOutputConnector connector;
4949
private final String s3BucketName;
5050
private final String s3KeyPrefix;

0 commit comments

Comments
 (0)