EOL code-generator/generate-groups scripts

thockin · k8s-publishing-bot · commit 2e5be312636d · 2024-01-16T22:20:02.000-08:00
There's no easy way to make it work in the new model.  Callers add flags
to the commandline like:

```
"${CODEGEN_PKG}/generate-internal-groups.sh" "client,conversion,deepcopy,defaulter,informer,lister,openapi" \
  k8s.io/code-generator/examples/apiserver \
  k8s.io/code-generator/examples/apiserver/apis \
  k8s.io/code-generator/examples/apiserver/apis \
  "example:v1 example2:v1 example3.io:v1" \
  --output-base "${SCRIPT_DIR}/../../../.." \
  --go-header-file "${SCRIPT_DIR}/boilerplate.go.txt"
```

To support this we would need to parse these flags in these scripts and
try to adapt them to the new CLI tool interfaces.  Not impossible, but
seeing as we deprecated these a few releases ago AND that we have other
breaking changes to the tools, let's just rip this bandaid off?

Kubernetes-commit: 7776496309c49f91c15ca929d6e27442ae6b83dc
diff --git a/generate-groups.sh b/generate-groups.sh
@@ -14,53 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-set -o errexit
-set -o nounset
-set -o pipefail
-
-# generate-groups generates everything for a project with external types only, e.g. a project based
-# on CustomResourceDefinitions.
-
-if [ "$#" -lt 4 ] || [ "${1}" == "--help" ]; then
-  cat <<EOF
-Usage: $(basename "$0") <generators> <output-package> <apis-package> <groups-versions> ...
-
-  <generators>        the generators comma separated to run (deepcopy,defaulter,applyconfiguration,client,lister,informer).
-  <output-package>    the output package name (e.g. github.com/example/project/pkg/generated).
-  <apis-package>      the external types dir (e.g. github.com/example/api or github.com/example/project/pkg/apis).
-  <groups-versions>   the groups and their versions in the format "groupA:v1,v2 groupB:v1 groupC:v2", relative
-                      to <api-package>.
-  ...                 arbitrary flags passed to all generator binaries.
-
-
-Example:
-  $(basename "$0") \
-      deepcopy,client \
-      github.com/example/project/pkg/client \
-      github.com/example/project/pkg/apis \
-      "foo:v1 bar:v1alpha1,v1beta1"
-EOF
-  exit 0
-fi
-
-GENS="$1"
-OUTPUT_PKG="$2"
-APIS_PKG="$3"
-GROUPS_WITH_VERSIONS="$4"
-shift 4
-
-echo "WARNING: $(basename "$0") is deprecated."
-echo "WARNING: Please use k8s.io/code-generator/kube_codegen.sh instead."
+echo "ERROR: $(basename "$0") has been removed."
+echo "ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead."
 echo
-
-if [ "${GENS}" = "all" ] || grep -qw "all" <<<"${GENS}"; then
-    ALL="applyconfiguration,client,deepcopy,informer,lister"
-    echo "WARNING: Specifying \"all\" as a generator is deprecated."
-    echo "WARNING: Please list the specific generators needed."
-    echo "WARNING: \"all\" is now an alias for \"${ALL}\"; new code generators WILL NOT be added to this set"
-    echo
-    GENS="${ALL}"
-fi
-
-INT_APIS_PKG=""
-exec "$(dirname "${BASH_SOURCE[0]}")/generate-internal-groups.sh" "${GENS}" "${OUTPUT_PKG}" "${INT_APIS_PKG}" "${APIS_PKG}" "${GROUPS_WITH_VERSIONS}" "$@"
+exit 1
diff --git a/generate-internal-groups.sh b/generate-internal-groups.sh
@@ -14,281 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-set -o errexit
-set -o nounset
-set -o pipefail
-
-# generate-internal-groups generates everything for a project with internal types, e.g. an
-# user-provided API server based on k8s.io/apiserver.
-
-if [ "$#" -lt 5 ] || [ "${1}" == "--help" ]; then
-  cat <<EOF
-Usage: $(basename "$0") <generators> <output-package> <internal-apis-package> <extensiona-apis-package> <groups-versions> ...
-
-  <generators>        the generators comma separated to run (applyconfiguration,client,conversion,deepcopy,defaulter,informer,lister,openapi).
-  <output-package>    the output package name (e.g. github.com/example/project/pkg/generated).
-  <int-apis-package>  the internal types dir (e.g. github.com/example/project/pkg/apis) or "" if none.
-  <ext-apis-package>  the external types dir (e.g. github.com/example/project/pkg/apis or githubcom/example/apis).
-  <groups-versions>   the groups and their versions in the format "groupA:v1,v2 groupB:v1 groupC:v2", relative
-                      to <api-package>.
-  ...                 arbitrary flags passed to all generator binaries.
-
-Example:
-  $(basename "$0") \
-      deepcopy,defaulter,conversion \
-      github.com/example/project/pkg/client \
-      github.com/example/project/pkg/apis \
-      github.com/example/project/apis \
-      "foo:v1 bar:v1alpha1,v1beta1"
-EOF
-  exit 0
-fi
-
-GENS="$1"
-OUTPUT_PKG="$2"
-INT_APIS_PKG="$3"
-EXT_APIS_PKG="$4"
-GROUPS_WITH_VERSIONS="$5"
-shift 5
-
-echo "WARNING: $(basename "$0") is deprecated."
-echo "WARNING: Please use k8s.io/code-generator/kube_codegen.sh instead."
+echo "ERROR: $(basename "$0") has been removed."
+echo "ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead."
 echo
-
-# If verification only is requested, avoid deleting files
-verify_only=""
-for ((i = 1; i <= $#; i++)); do
-    if [ "${!i}" = --verify-only ]; then verify_only=1; fi
-done
-
-if [ "${GENS}" = "all" ] || grep -qw "all" <<<"${GENS}"; then
-    ALL="client,conversion,deepcopy,defaulter,informer,lister,openapi"
-    echo "WARNING: Specifying \"all\" as a generator is deprecated."
-    echo "WARNING: Please list the specific generators needed."
-    echo "WARNING: \"all\" is now an alias for \"${ALL}\"; new code generators WILL NOT be added to this set"
-    echo
-    GENS="${ALL}"
-fi
-
-(
-  # To support running this script from anywhere, first cd into this directory,
-  # and then install with forced module mode on and fully qualified name.
-  cd "$(dirname "${0}")"
-  BINS=(
-      applyconfiguration-gen
-      client-gen
-      conversion-gen
-      deepcopy-gen
-      defaulter-gen
-      informer-gen
-      lister-gen
-      openapi-gen
-  )
-  # Compile all the tools at once - it's slightly faster but also just simpler.
-  # shellcheck disable=2046 # printf word-splitting is intentional
-  GO111MODULE=on go install $(printf "k8s.io/code-generator/cmd/%s " "${BINS[@]}")
-)
-
-# Go installs the above commands to get installed in $GOBIN if defined, and $GOPATH/bin otherwise:
-GOBIN="$(go env GOBIN)"
-gobin="${GOBIN:-$(go env GOPATH)/bin}"
-
-function git_find() {
-    # Similar to find but faster and easier to understand.  We want to include
-    # modified and untracked files because this might be running against code
-    # which is not tracked by git yet.
-    git ls-files -cmo --exclude-standard "$@"
-}
-
-function git_grep() {
-    # We want to include modified and untracked files because this might be
-    # running against code which is not tracked by git yet.
-    git grep --untracked "$@"
-}
-function codegen::join() { local IFS="$1"; shift; echo "$*"; }
-
-# enumerate group versions
-ALL_FQ_APIS=() # e.g. k8s.io/kubernetes/pkg/apis/apps k8s.io/api/apps/v1
-EXT_FQ_APIS=() # e.g. k8s.io/api/apps/v1
-GROUP_VERSIONS=() # e.g. apps/v1
-for GVs in ${GROUPS_WITH_VERSIONS}; do
-  IFS=: read -r G Vs <<<"${GVs}"
-
-  if [ -n "${INT_APIS_PKG}" ]; then
-    ALL_FQ_APIS+=("${INT_APIS_PKG}/${G}")
-  fi
-
-  # enumerate versions
-  for V in ${Vs//,/ }; do
-    ALL_FQ_APIS+=("${EXT_APIS_PKG}/${G}/${V}")
-    EXT_FQ_APIS+=("${EXT_APIS_PKG}/${G}/${V}")
-    GROUP_VERSIONS+=("${G}/${V}")
-  done
-done
-
-CLIENTSET_PKG="${CLIENTSET_PKG_NAME:-clientset}"
-CLIENTSET_NAME="${CLIENTSET_NAME_VERSIONED:-versioned}"
-
-if grep -qw "deepcopy" <<<"${GENS}"; then
-  if [ ! "$verify_only" ]; then
-    # Nuke existing files
-    for dir in $(GO111MODULE=on go list -f '{{.Dir}}' "${ALL_FQ_APIS[@]}"); do
-      pushd "${dir}" >/dev/null
-      git_find -z ':(glob)**'/zz_generated.deepcopy.go | xargs -0 rm -f
-      popd >/dev/null
-    done
-  fi
-
-  echo "Generating deepcopy funcs"
-  "${gobin}/deepcopy-gen" \
-      --input-dirs "$(codegen::join , "${ALL_FQ_APIS[@]}")" \
-      -O zz_generated.deepcopy \
-      "$@"
-fi
-
-if grep -qw "defaulter" <<<"${GENS}"; then
-  if [ ! "$verify_only" ]; then
-    # Nuke existing files
-    for dir in $(GO111MODULE=on go list -f '{{.Dir}}' "${ALL_FQ_APIS[@]}"); do
-      pushd "${dir}" >/dev/null
-      git_find -z ':(glob)**'/zz_generated.defaults.go | xargs -0 rm -f
-      popd >/dev/null
-    done
-  fi
-
-  echo "Generating defaulters"
-  "${gobin}/defaulter-gen"  \
-      --input-dirs "$(codegen::join , "${EXT_FQ_APIS[@]}")" \
-      -O zz_generated.defaults \
-      "$@"
-fi
-
-if grep -qw "conversion" <<<"${GENS}"; then
-  if [ ! "$verify_only" ]; then
-    # Nuke existing files
-    for dir in $(GO111MODULE=on go list -f '{{.Dir}}' "${ALL_FQ_APIS[@]}"); do
-      pushd "${dir}" >/dev/null
-      git_find -z ':(glob)**'/zz_generated.conversion.go | xargs -0 rm -f
-      popd >/dev/null
-    done
-  fi
-
-  echo "Generating conversions"
-  "${gobin}/conversion-gen" \
-      --input-dirs "$(codegen::join , "${ALL_FQ_APIS[@]}")" \
-      -O zz_generated.conversion \
-      "$@"
-fi
-
-if grep -qw "applyconfiguration" <<<"${GENS}"; then
-  APPLY_CONFIGURATION_PACKAGE="${OUTPUT_PKG}/${APPLYCONFIGURATION_PKG_NAME:-applyconfiguration}"
-
-  if [ ! "$verify_only" ]; then
-    # Nuke existing files
-    root="$(GO111MODULE=on go list -f '{{.Dir}}' "${APPLY_CONFIGURATION_PACKAGE}" 2>/dev/null || true)"
-    if [ -n "${root}" ]; then
-      pushd "${root}" >/dev/null
-      git_grep -l --null \
-        -e '^// Code generated by applyconfiguration-gen. DO NOT EDIT.$' \
-        ':(glob)**/*.go' \
-        | xargs -0 rm -f
-      popd >/dev/null
-    fi
-  fi
-
-  echo "Generating apply configuration for ${GROUPS_WITH_VERSIONS} at ${APPLY_CONFIGURATION_PACKAGE}"
-  "${gobin}/applyconfiguration-gen" \
-      --input-dirs "$(codegen::join , "${EXT_FQ_APIS[@]}")" \
-      --output-package "${APPLY_CONFIGURATION_PACKAGE}" \
-      "$@"
-fi
-
-if grep -qw "client" <<<"${GENS}"; then
-  if [ ! "$verify_only" ]; then
-    # Nuke existing files
-    root="$(GO111MODULE=on go list -f '{{.Dir}}' "${OUTPUT_PKG}/${CLIENTSET_PKG}/${CLIENTSET_NAME}" 2>/dev/null || true)"
-    if [ -n "${root}" ]; then
-      pushd "${root}" >/dev/null
-      git_grep -l --null \
-        -e '^// Code generated by client-gen. DO NOT EDIT.$' \
-        ':(glob)**/*.go' \
-        | xargs -0 rm -f
-      popd >/dev/null
-    fi
-  fi
-
-  echo "Generating clientset for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/${CLIENTSET_PKG}"
-  "${gobin}/client-gen" \
-      --clientset-name "${CLIENTSET_NAME}" \
-      --input-base "" \
-      --input "$(codegen::join , "${EXT_FQ_APIS[@]}")" \
-      --output-package "${OUTPUT_PKG}/${CLIENTSET_PKG}" \
-      --apply-configuration-package "${APPLY_CONFIGURATION_PACKAGE:-}" \
-      "$@"
-fi
-
-if grep -qw "lister" <<<"${GENS}"; then
-  if [ ! "$verify_only" ]; then
-    # Nuke existing files
-    for gv in "${GROUP_VERSIONS[@]}"; do
-      root="$(GO111MODULE=on go list -f '{{.Dir}}' "${OUTPUT_PKG}/listers/${gv}" 2>/dev/null || true)"
-      if [ -n "${root}" ]; then
-        pushd "${root}" >/dev/null
-        git_grep -l --null \
-          -e '^// Code generated by lister-gen. DO NOT EDIT.$' \
-          ':(glob)**/*.go' \
-          | xargs -0 rm -f
-        popd >/dev/null
-      fi
-    done
-  fi
-
-  echo "Generating listers for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/listers"
-  "${gobin}/lister-gen" \
-      --input-dirs "$(codegen::join , "${EXT_FQ_APIS[@]}")" \
-      --output-package "${OUTPUT_PKG}/listers" \
-      "$@"
-fi
-
-if grep -qw "informer" <<<"${GENS}"; then
-  if [ ! "$verify_only" ]; then
-    # Nuke existing files
-    root="$(GO111MODULE=on go list -f '{{.Dir}}' "${OUTPUT_PKG}/informers/externalversions" 2>/dev/null || true)"
-    if [ -n "${root}" ]; then
-      pushd "${root}" >/dev/null
-      git_grep -l --null \
-        -e '^// Code generated by informer-gen. DO NOT EDIT.$' \
-        ':(glob)**/*.go' \
-        | xargs -0 rm -f
-      popd >/dev/null
-    fi
-  fi
-
-  echo "Generating informers for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/informers"
-  "${gobin}/informer-gen" \
-      --input-dirs "$(codegen::join , "${EXT_FQ_APIS[@]}")" \
-      --versioned-clientset-package "${OUTPUT_PKG}/${CLIENTSET_PKG}/${CLIENTSET_NAME}" \
-      --listers-package "${OUTPUT_PKG}/listers" \
-      --output-package "${OUTPUT_PKG}/informers" \
-      "$@"
-fi
-
-if grep -qw "openapi" <<<"${GENS}"; then
-  if [ ! "$verify_only" ]; then
-    # Nuke existing files
-    for dir in $(GO111MODULE=on go list -f '{{.Dir}}' "${FQ_APIS[@]}"); do
-      pushd "${dir}" >/dev/null
-      git_find -z ':(glob)**'/zz_generated.openapi.go | xargs -0 rm -f
-      popd >/dev/null
-    done
-  fi
-
-  echo "Generating OpenAPI definitions for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/openapi"
-  declare -a OPENAPI_EXTRA_PACKAGES
-  "${gobin}/openapi-gen" \
-      --input-dirs "$(codegen::join , "${EXT_FQ_APIS[@]}" "${OPENAPI_EXTRA_PACKAGES[@]+"${OPENAPI_EXTRA_PACKAGES[@]}"}")" \
-      --input-dirs "k8s.io/apimachinery/pkg/apis/meta/v1,k8s.io/apimachinery/pkg/runtime,k8s.io/apimachinery/pkg/version" \
-      --output-package "${OUTPUT_PKG}/openapi" \
-      -O zz_generated.openapi \
-      "$@"
-fi
+exit 1
