Skip to content

Commit e36919e

Browse files
committed
Merge remote-tracking branch 'origin/main' into import-conditions
2 parents f408683 + 56109e7 commit e36919e

File tree

7 files changed

+231
-356
lines changed

7 files changed

+231
-356
lines changed

.changeset/config.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"$schema": "https://unpkg.com/@changesets/config@1.6.0/schema.json",
2+
"$schema": "https://unpkg.com/@changesets/config@3.0.2/schema.json",
33
"changelog": [
44
"@changesets/changelog-github",
55
{ "repo": "emotion-js/emotion" }
@@ -23,6 +23,7 @@
2323
]
2424
],
2525
"access": "public",
26+
"privatePackages": false,
2627
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
2728
"onlyUpdatePeerDependentsWhenOutOfRange": true
2829
}

.changeset/metal-boxes-admire.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@emotion/primitives-core': patch
3+
'@emotion/styled': patch
4+
'@emotion/react': patch
5+
---
6+
7+
Only forward defined `ref`s to improve compatibility with the upcoming React 19

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@
180180
"@babel/preset-typescript": "^7.18.6",
181181
"@babel/register": "^7.17.7",
182182
"@babel/runtime": "^7.18.3",
183-
"@changesets/changelog-github": "^0.4.0",
184-
"@changesets/cli": "^2.16.0",
183+
"@changesets/changelog-github": "^0.5.0",
184+
"@changesets/cli": "^2.27.7",
185185
"@manypkg/cli": "^0.19.1",
186186
"@preconstruct/cli": "^2.8.4",
187187
"@testing-library/react": "13.0.0-alpha.5",

packages/primitives-core/src/styled.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,10 @@ export function createStyled(
7676
newProps[key] = props[key]
7777
}
7878
}
79-
8079
newProps.style = [css.apply(mergedProps, styles), props.style]
81-
newProps.ref = ref
80+
if (ref) {
81+
newProps.ref = ref
82+
}
8283

8384
return React.createElement(finalTag, newProps)
8485
})

packages/react/src/emotion-element.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,10 @@ let Emotion = /* #__PURE__ */ withEmotionCache(
148148
newProps[key] = props[key]
149149
}
150150
}
151-
newProps.ref = ref
152151
newProps.className = className
152+
if (ref) {
153+
newProps.ref = ref
154+
}
153155

154156
return (
155157
<>

packages/styled/src/base.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,10 @@ let createStyled /*: CreateStyled */ = (
155155
newProps[key] = props[key]
156156
}
157157
}
158-
159158
newProps.className = className
160-
newProps.ref = ref
159+
if (ref) {
160+
newProps.ref = ref
161+
}
161162

162163
return (
163164
<>

0 commit comments

Comments
 (0)