Skip to content

Commit 78dc4bf

Browse files
committed
Remove stripping of individual command line arguments in emcc.py.
This was originally introduced 10 years ago to work around a bug that occurred on windows vista (See 4ab1c8a). Its not clear if the bug was in cmake or in windows itself, or in the version of python. Windows Vista has been unsupported for a very long time now so I think ever attempted to verify this bug still exists would be very tricky. What is more, the underlying tools such as clang don't support this behavior so any user who suffered from this bug likely wouldn't be able ot use clang outside of emscripten. For example: ``` clang ' --version' clang: error: no such file or directory: ' --version'; did you mean '--version'? clang: error: no input files ``` I don't know of any tools that don't work like that above, so I don't see why we should be any different. The motivation for removing this now is that it came up in discussion when working on code nearby (#16087) and it seems to pointless at best and is also a compatibility issue (since it prevents the use of filenames that start or end in space).
1 parent e7be51f commit 78dc4bf

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

emcc.py

-3
Original file line numberDiff line numberDiff line change
@@ -2918,9 +2918,6 @@ def parse_args(newargs):
29182918
skip = False
29192919
continue
29202920

2921-
# On Windows Vista (and possibly others), excessive spaces in the command line
2922-
# leak into the items in this array, so trim e.g. 'foo.cpp ' -> 'foo.cpp'
2923-
newargs[i] = newargs[i].strip()
29242921
arg = newargs[i]
29252922
arg_value = None
29262923

0 commit comments

Comments
 (0)