Skip to content

Commit fa311fa

Browse files
authored
Bump v8 to 9.1.269, update V8 flags for SIMD (#14171)
--experimental-wasm-simd is no longer needed for v8.
1 parent 7152cda commit fa311fa

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.circleci/config.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ executors:
1616
EMCC_CORES: "4"
1717
EMSDK_NOTTY: "1"
1818
EMTEST_WASI_SYSROOT: "~/wasi-sdk/wasi-sysroot"
19-
# Currently pinned to 9.1.146 due to https://bugs.chromium.org/p/v8/issues/detail?id=11581
20-
V8_VERSION: "9.1.146"
2119
mac:
2220
environment:
2321
EMSDK_NOTTY: "1"
@@ -59,7 +57,8 @@ commands:
5957
# test v8 with --wasm-staging which enables new features. we use v8
6058
# as a "bleeding edge" shell here, basically, with node being the
6159
# primary shell (which we run without any special flags)
62-
echo "V8_ENGINE = [os.path.expanduser('~/.jsvu/v8-${V8_VERSION}'), '--wasm-staging']" >> .emscripten
60+
# Refer to commit 0bc3640 if we need to pin V8 version.
61+
echo "V8_ENGINE = [os.path.expanduser('~/.jsvu/v8'), '--wasm-staging']" >> .emscripten
6362
echo "JS_ENGINES = [NODE_JS]" >> .emscripten
6463
echo "if os.path.exists(V8_ENGINE[0]): JS_ENGINES.append(V8_ENGINE)" >> .emscripten
6564
echo "WASM_ENGINES = []" >> .emscripten
@@ -394,7 +393,7 @@ jobs:
394393
export PATH="`pwd`/node-v12.13.0-linux-x64/bin:${PATH}"
395394
npm install jsvu -g
396395
export PATH="${HOME}/.jsvu:${PATH}"
397-
jsvu --os=default --engines=v8 v8@${V8_VERSION}
396+
jsvu --os=default --engines=v8
398397
- build
399398
- build-libs-and-freeze
400399
- persist

0 commit comments

Comments
 (0)