Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHONE_DISPLAY_SEPARATOR set to blank (" ") causes problems #133

Open
emxsys opened this issue Nov 19, 2020 · 1 comment
Open

PHONE_DISPLAY_SEPARATOR set to blank (" ") causes problems #133

emxsys opened this issue Nov 19, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@emxsys
Copy link
Owner

emxsys commented Nov 19, 2020

From a forum user:

I’ve found another small problem. Since I use a blank as the phone display separator I’m not able to use the trash can to delete items from the permitted list. In this case I think you need to make the phone number in the onclick action HTML safe and my blank would become %20 and change the action from ‘/callers/permitted/delete/07981 734697’ to ‘/callers/permitted/delete/07981%20734697’.

@emxsys emxsys added the bug Something isn't working label Nov 19, 2020
@emxsys emxsys added this to the Release 1.1.1 milestone Nov 19, 2020
@emxsys emxsys self-assigned this Nov 19, 2020
@emxsys
Copy link
Owner Author

emxsys commented Nov 20, 2020

Per user forum comment:

It seems to be a browser related issue. The script works with Firefox but not with Microsoft Edge (Version 87.0.664.41) based on Google chromium engine although using Chrome itself it also works. I’ve copied the HTML for the ‘permitted’ page and changed the separator in the onclick to %20 and then Edge does delete the number. I also changed the display separator to ‘-‘ and replaced the blank in the display format with a ‘-‘ and then the delete works in all browsers.

Me: I just loathe browser incompatibility issues. <sigh!>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant