From 6bc671f06c11f31a8e4e92df1aca24329205ee5e Mon Sep 17 00:00:00 2001 From: Niko PLP Date: Tue, 6 Aug 2024 16:11:30 +0300 Subject: [PATCH 1/2] fix: cannot read properties of undefined --- packages/plugin-split-editing/src/codemirror.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/plugin-split-editing/src/codemirror.ts b/packages/plugin-split-editing/src/codemirror.ts index 7c176d7..86c681f 100644 --- a/packages/plugin-split-editing/src/codemirror.ts +++ b/packages/plugin-split-editing/src/codemirror.ts @@ -22,6 +22,7 @@ import { rectangularSelection, } from '@codemirror/view' import { $ctx } from '@milkdown/utils' +import { StyleModule } from 'style-mod' import { Options } from '.' const basicSetup: Extension = [ @@ -72,9 +73,13 @@ export class CodemirrorEditor { extensions: [ basicSetup, markdown(), - EditorView.styleModule.of({ - getRules: () => '.cm-editor{height:100%}', - }), + EditorView.styleModule.of( + new StyleModule({ + '.cm-editor': { + height: '100%', + }, + }), + ), EditorView.lineWrapping, updateListener, ...extensions, From ce7e2a8a727a26e0b586cddecfd320335989a6af Mon Sep 17 00:00:00 2001 From: Niko PLP Date: Wed, 7 Aug 2024 10:18:58 +0300 Subject: [PATCH 2/2] fix: adding dependency to package.json --- packages/plugin-split-editing/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/plugin-split-editing/package.json b/packages/plugin-split-editing/package.json index 09122f3..93f7db5 100644 --- a/packages/plugin-split-editing/package.json +++ b/packages/plugin-split-editing/package.json @@ -27,8 +27,9 @@ "devDependencies": { "@milkdown/core": "^7.4.0", "@milkdown/prose": "^7.4.0", + "style-mod": "^4.1.0", "tsup": "^8.2.4", - "typescript": "^5.5.4" + "typescript": "^5.5.4", }, "dependencies": { "@codemirror/commands": "^6.6.0",