further tweaking to is_trivial_query

Author: radeusgd

distribution/lib/Standard/Database/0.0.0-dev/src/DB_Table.enso

@@ -2747,13 +2747,18 @@ type DB_Table
        Some operations, like writing to tables, require their target to be a
        trivial query.
     is_trivial_query self -> Boolean ! Table_Not_Found =
-         trivial_counterpart = self.connection.query (SQL_Query.Table_Name self.name)
-         if trivial_counterpart.is_error then False else
-             if self.context != trivial_counterpart.context then False else
-                column_descriptor internal_column = [internal_column.name, internal_column.expression]
-                my_columns = self.internal_columns.map column_descriptor
-                trivial_columns = trivial_counterpart.internal_columns.map column_descriptor
-                my_columns == trivial_columns
+        case self.context.from_spec of
+            From_Spec.Table internal_table_name _ _ ->
+                if self.name != internal_table_name then False else
+                    trivial_counterpart = self.connection.query (SQL_Query.Table_Name self.name)
+                    # If the table spec seems trivial, but the underlying table does not exist, we propagate the Table_Not_Found error.
+                    trivial_counterpart.if_not_error <|
+                        if self.context != trivial_counterpart.context then False else
+                           column_descriptor internal_column = [internal_column.name, internal_column.expression]
+                           my_columns = self.internal_columns.map column_descriptor
+                           trivial_columns = trivial_counterpart.internal_columns.map column_descriptor
+                           my_columns == trivial_columns
+            _ -> False
 
     ## PRIVATE
        Provides a simplified text representation for display in the REPL and errors.

test/Table_Tests/src/Database/Upload_Spec.enso

@@ -518,7 +518,7 @@ add_specs suite_builder setup make_new_connection persistent_connector=True =
             db_table_3 = db_table_1.aggregate ["X"] [Aggregate_Column.Sum (expr "[Y]*[Y]") "C3"] . set (expr "[X] + 1") "X"
 
             db_table_4 = db_table_2.join db_table_3 join_kind=Join_Kind.Left_Outer
-            db_table_4.is_trivial_query . should_fail_with Table_Not_Found
+            db_table_4.is_trivial_query . should_be_false
 
             copied_table = db_table_4.select_into_database_table data.connection (Name_Generator.random_name "copied-table") temporary=True primary_key=Nothing
             copied_table.column_names . should_equal ["X", "Y", "C1", "C2", "Right X", "C3"]