on_missing behavior for managed resources that get access after being finalized

Author: JaroslavTulach

distribution/lib/Standard/Base/0.0.0-dev/src/Runtime/Managed_Resource.enso

@@ -73,11 +73,13 @@ type Managed_Resource
        Arguments:
        - action: The action that will be applied to the resource managed by
          resource.
+       - on_missing: Optional action to perform when the value is no longer
+         reachable
        Returns:
        Value returned from the `action` or `Nothing` if the managed resource
        was already finalized
-    with : (Any -> Any) -> Any
-    with self ~action = @Builtin_Method "Managed_Resource.with"
+    with : (Any -> Any) -> Any -> Any
+    with self ~action ~on_missing=Nothing = with_builtin self action on_missing...
 
     ## PRIVATE
        ADVANCED
@@ -89,3 +91,4 @@ type Managed_Resource
     take self = @Builtin_Method "Managed_Resource.take"
 
 register_builtin r fn sys:Boolean = @Builtin_Method "Managed_Resource.register_builtin"
+with_builtin r fn ~on_missing = @Builtin_Method "Managed_Resource.with_builtin"

distribution/lib/Standard/Base/0.0.0-dev/src/System/Input_Stream.enso

@@ -4,6 +4,7 @@ import project.Data.Numbers.Integer
 import project.Data.Text.Encoding.Encoding
 import project.Data.Vector.Vector
 import project.Error.Error
+import project.Panic.Panic
 import project.Errors.File_Error.File_Error
 import project.Errors.Illegal_State.Illegal_State
 import project.Errors.Problem_Behavior.Problem_Behavior
@@ -17,6 +18,7 @@ import project.System.File.Generic.Writable_File.Writable_File
 import project.System.Internal.Reporting_Stream_Decoder_Helper
 from project.Data.Boolean import Boolean, False, True
 
+polyglot java import java.io.IOException
 polyglot java import java.io.BufferedInputStream
 polyglot java import java.io.ByteArrayInputStream
 polyglot java import java.io.InputStream as Java_Input_Stream
@@ -114,9 +116,10 @@ type Input_Stream
        Arguments:
        - f: Applies a function over the internal java stream.
     with_java_stream : (Java_Input_Stream -> Any) -> Any
-    with_java_stream self f = self.stream_resource . with java_like_stream->
-        java_stream = Stream_Utils.asInputStream java_like_stream
-        self.error_handler <| f java_stream
+    with_java_stream self f =
+        self.stream_resource . with on_missing=(Panic.throw <| IOException.new "Stream closed") java_like_stream->
+            java_stream = Stream_Utils.asInputStream java_like_stream
+            self.error_handler <| f java_stream
 
     ## PRIVATE
        Runs an action with a `ReportingStreamDecoder` decoding data from the

engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/resource/WithNode.java

@@ -1,6 +1,5 @@
 package org.enso.interpreter.node.expression.builtin.resource;
 
-import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.VirtualFrame;
 import com.oracle.truffle.api.nodes.Node;
 import org.enso.interpreter.dsl.BuiltinMethod;
@@ -12,11 +11,12 @@
 
 @BuiltinMethod(
     type = "Managed_Resource",
-    name = "with",
+    name = "with_builtin",
     description =
         "Applies the passed action to the underlying resource managed by the passed"
             + " Managed_Resource object.")
-public abstract class WithNode extends Node {
+public final class WithNode extends Node {
+  private WithNode() {}
 
   private @Child InvokeCallableNode invokeCallableNode =
       InvokeCallableNode.build(
@@ -25,24 +25,22 @@ public abstract class WithNode extends Node {
           InvokeCallableNode.ArgumentsExecutionMode.PRE_EXECUTED);
 
   static WithNode build() {
-    return WithNodeGen.create();
+    return new WithNode();
   }
 
-  abstract Object execute(State state, VirtualFrame frame, Object self, Object action);
-
-  @Specialization
-  Object doWith(State state, VirtualFrame frame, ManagedResource self, Object action) {
+  Object execute(
+      State state, VirtualFrame frame, ManagedResource mr, Object action, Object onMissing) {
     var ctx = EnsoContext.get(this);
     var resourceManager = ctx.getResourceManager();
-    if (self.getPhantomReference().refersTo(self)) {
-      resourceManager.park(self);
+    if (mr.getPhantomReference().refersTo(mr)) {
+      resourceManager.park(mr);
       try {
-        return invokeCallableNode.execute(action, frame, state, new Object[] {self.getResource()});
+        return invokeCallableNode.execute(action, frame, state, new Object[] {mr.getResource()});
       } finally {
-        resourceManager.unpark(self);
+        resourceManager.unpark(mr);
       }
     } else {
-      return ctx.getBuiltins().nothing();
+      return onMissing;
     }
   }
 }