Skip to content

Commit 48f23a1

Browse files
authored
Make side bar icons match between dashboard and graph editor (#12410)
* Make side bar icons match between dashboard and graph editor * Code review feedback * Fix * corepack pnpm run ci:prettier --write
1 parent 4b827c3 commit 48f23a1

File tree

3 files changed

+25
-13
lines changed

3 files changed

+25
-13
lines changed

app/gui/src/project-view/assets/icons.svg

Lines changed: 17 additions & 3 deletions
Loading

app/gui/src/project-view/components/DockPanel.vue

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import { documentationEditorBindings } from '@/bindings'
33
import ResizeHandles from '@/components/ResizeHandles.vue'
44
import SizeTransition from '@/components/SizeTransition.vue'
5+
import SvgButton from '@/components/SvgButton.vue'
56
import ToggleIcon from '@/components/ToggleIcon.vue'
67
import { useResizeObserver } from '@/composables/events'
78
import { Rect } from '@/util/data/rect'
@@ -65,14 +66,10 @@ const tabStyle = {
6566
v-for="{ tab, title, icon } in props.tabButtons"
6667
:key="tab"
6768
class="tab"
69+
:class="{ activeTab: currentTab === tab }"
6870
:style="tabStyle"
6971
>
70-
<ToggleIcon
71-
:modelValue="currentTab == tab"
72-
:title="title"
73-
:icon="icon"
74-
@update:modelValue="currentTab = tab"
75-
/>
72+
<SvgButton :title="title" :name="icon" @click="currentTab = tab" />
7673
</div>
7774
</div>
7875
<ResizeHandles
@@ -135,9 +132,10 @@ const tabStyle = {
135132
display: flex;
136133
align-items: center;
137134
justify-content: center;
138-
&:has(.toggledOn) {
139-
background-color: #fff;
140-
}
135+
}
136+
137+
.activeTab {
138+
background-color: #fff;
141139
}
142140
143141
.toggleDock {

app/gui/src/project-view/stores/rightDock.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export type RightDockStore = ReturnType<typeof useRightDock>
1414

1515
export type RightDockTab = ExtractTabs<typeof tabButtons>
1616
export const { buttons: tabButtons, isValidTab } = defineTabButtons([
17-
{ tab: 'docs', icon: 'text', title: 'Documentation Editor' },
17+
{ tab: 'docs', icon: 'document', title: 'Documentation Editor' },
1818
{ tab: 'help', icon: 'help', title: 'Component Help' },
1919
])
2020

0 commit comments

Comments
 (0)