Build script cleanups (#9931)

This PR removes unused, commented-out or otherwise spurious code from build script. Also, dependencies were reviewed and cleaned.

No functional changes intended.

Author: mwu-tow

Cargo.lock

@@ -11,14 +11,12 @@ aws-sdk-ecr = "0.21.0"
 aws-sdk-s3 = "0.21.0"
 base64 = "0.13.0"
 bytes = { workspace = true }
-byte-unit = { workspace = true }
 chrono = { workspace = true }
 clap = { workspace = true }
 derivative = { workspace = true }
 derive_more = { workspace = true }
 dirs = { workspace = true }
 futures = { workspace = true }
-futures-util = "0.3.17"
 glob = "0.3.0"
 handlebars = "4.3.5"
 heck = "0.4.0"

build/build/Cargo.toml

@@ -128,15 +128,6 @@ mod tests {
     use super::*;
 
 
-    // #[tokio::test]
-    // async fn aaa() -> Result {
-    //     let repo = RepoContext::from_str("enso-org/enso")?;
-    //     let paths =
-    //         Paths::new_version(r"H:\NBO\enso", Version::parse("2022.1.1-nightly.2022-01-28")?)?;
-    //     update_manifest(&repo, &paths).await?;
-    //     Ok(())
-    // }
-
     #[test]
     fn updating_manifest() -> Result {
         let old_nightly = serde_yaml::from_str::<Manifest>(

build/build/examples/experiments.rs

@@ -9,7 +9,6 @@ use crate::version::ENSO_VERSION;
 
 use anyhow::Context;
 use ide_ci::env::known::electron_builder::WindowsSigningCredentials;
-use ide_ci::io::download_all;
 use ide_ci::program::command::FallibleManipulator;
 use ide_ci::programs::node::NpmCommand;
 use ide_ci::programs::Npm;
@@ -36,11 +35,6 @@ lazy_static! {
     pub static ref BUILD_INFO: PathBuf = PathBuf::from("build.json");
 }
 
-pub const IDE_ASSETS_URL: &str =
-    "https://github.com/enso-org/ide-assets/archive/refs/heads/main.zip";
-
-pub const ARCHIVED_ASSET_FILE: &str = "ide-assets-main/content/assets/";
-
 pub mod env {
     use super::*;
 
@@ -148,16 +142,6 @@ impl FallibleManipulator for IconsArtifacts {
     }
 }
 
-/// Fill the directory under `output_path` with the assets.
-pub async fn download_js_assets(output_path: impl AsRef<Path>) -> Result {
-    let output = output_path.as_ref();
-    let archived_asset_prefix = PathBuf::from(ARCHIVED_ASSET_FILE);
-    let archive = download_all(IDE_ASSETS_URL).await?;
-    let mut archive = zip::ZipArchive::new(std::io::Cursor::new(archive))?;
-    ide_ci::archive::zip::extract_subtree(&mut archive, &archived_asset_prefix, output)?;
-    Ok(())
-}
-
 /// Get a relative path to the Project Manager executable in the PM bundle.
 pub fn path_to_executable_in_pm_bundle(
     artifact: &generated::ProjectManagerBundle,
@@ -370,15 +354,3 @@ impl IdeDesktop {
         Ok(())
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[tokio::test]
-    async fn download_test() -> Result {
-        let temp = TempDir::new()?;
-        download_js_assets(temp.path()).await?;
-        Ok(())
-    }
-}

build/build/examples/s3.rs

@@ -33,7 +33,6 @@ pub mod prelude {
 }
 
 pub mod aws;
-pub mod bump_version;
 pub mod changelog;
 pub mod ci;
 pub mod ci_gen;

build/build/src/aws.rs

@@ -226,27 +226,4 @@ mod tests {
         std::mem::forget(child);
         Ok(())
     }
-
-    #[tokio::test]
-    #[ignore]
-    async fn test_postgres() -> Result {
-        // let config = Configuration {
-        //     postgres_container: ContainerId("something".into()),
-        //     endpoint:           EndpointConfiguration::deduce()?,
-        //     version:            "latest".into(),
-        //     user:               "test".into(),
-        //     password:           "test".into(),
-        //     database_name:      "test".into(),
-        // };
-        // let child = Postgresql::start(config).await?;
-        // std::mem::forget(child);
-        // // let mut httpbin = get_and_spawn_httpbin_on_free_port().await?;
-        // Command::new("cmd")
-        //     .args(["/c",
-        // "H:\\NBO\\enso2\\built-distribution\\enso-engine-0.2.32-SNAPSHOT-windows-amd64\\enso-0.2.
-        // 32-SNAPSHOT\\bin\\enso", "--no-ir-caches", "--run",
-        // "H:\\NBO\\enso2\\test\\Database_Tests"]).run_ok().await?; httpbin.process.kill().
-        // await?;
-        Ok(())
-    }
 }

build/build/src/bump_version.rs

@@ -25,10 +25,8 @@ use octocrab::models::repos::Asset;
 // ==============
 
 pub mod backend;
-pub mod engine;
 pub mod gui;
 pub mod ide;
-pub mod project_manager;
 pub mod runtime;
 pub mod wasm;
 
@@ -256,20 +254,6 @@ pub trait IsTarget: Clone + Debug + Sized + Send + Sync + 'static {
         todo!("Not implemented for target {self:?}!")
     }
 
-    // /// Upload the artifact as an asset to the GitHub release.
-    // fn upload_asset(
-    //     &self,
-    //     release_handle: ReleaseHandle,
-    //     output: impl Future<Output = Result<Self::Artifact>> + Send + 'static,
-    // ) -> BoxFuture<'static, Result> {
-    //     async move {
-    //         let artifact = output.await?;
-    //         release_handle.upload_compressed_dir(&artifact).await?;
-    //         Ok(())
-    //     }
-    //     .boxed()
-    // }
-
     fn download_asset(
         &self,
         context: Context,