Skip to content

Commit bf4b8ef

Browse files
committed
check invariants, run Snowflake on GH to have aws cli
1 parent a768c0b commit bf4b8ef

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.github/workflows/extra-nightly-tests.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@ on:
1414
default: false
1515
jobs:
1616
enso-build-ci-gen-job-snowflake-tests-linux-amd64:
17-
name: Snowflake Tests (linux, amd64)
17+
name: Snowflake Tests (LinuxLatest)
1818
runs-on:
19-
- self-hosted
20-
- Linux
19+
- ubuntu-latest
2120
steps:
2221
- if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
2322
name: Installing wasm-pack

build/build/src/ci_gen/job.rs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
use core::panic;
2+
13
use crate::prelude::*;
24

35
use crate::ci_gen::not_default_branch;
@@ -307,6 +309,10 @@ fn build_job_ensuring_cloud_tests_run_on_github(
307309
cloud_tests_enabled: bool,
308310
) -> Job {
309311
if cloud_tests_enabled {
312+
if target.0 != OS::Linux {
313+
panic!("If the Cloud tests are enabled, they require GitHub hosted runner for Cloud auth, so they only run on Linux.");
314+
}
315+
310316
run_steps_builder.build_job(job_name, RunnerLabel::LinuxLatest)
311317
} else {
312318
run_steps_builder.build_job(job_name, target)
@@ -320,6 +326,9 @@ const GRAAL_EDITION_FOR_EXTRA_TESTS: graalvm::Edition = graalvm::Edition::Commun
320326

321327
impl JobArchetype for SnowflakeTests {
322328
fn job(&self, target: Target) -> Job {
329+
if target.0 != OS::Linux {
330+
panic!("Snowflake tests currently require GitHub hosted runner for Cloud auth, so they only run on Linux.");
331+
}
323332
let job_name = "Snowflake Tests";
324333
let mut job = RunStepsBuilder::new("backend test std-snowflake")
325334
.customize(move |step| {
@@ -358,7 +367,7 @@ impl JobArchetype for SnowflakeTests {
358367
step::extra_stdlib_test_reporter(target, GRAAL_EDITION_FOR_EXTRA_TESTS),
359368
]
360369
})
361-
.build_job(job_name, target)
370+
.build_job(job_name, RunnerLabel::LinuxLatest)
362371
.with_permission(Permission::Checks, Access::Write);
363372
job.env(env::GRAAL_EDITION, GRAAL_EDITION_FOR_EXTRA_TESTS);
364373
job

0 commit comments

Comments
 (0)