check invariants, run Snowflake on GH to have aws cli

enso-org · Oct 22, 2024 · bf4b8ef · bf4b8ef
1 parent a768c0b
commit bf4b8ef
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/.github/workflows/extra-nightly-tests.yml b/.github/workflows/extra-nightly-tests.yml
@@ -14,10 +14,9 @@ on:
         default: false
 jobs:
   enso-build-ci-gen-job-snowflake-tests-linux-amd64:
-    name: Snowflake Tests (linux, amd64)
+    name: Snowflake Tests (LinuxLatest)
     runs-on:
-      - self-hosted
-      - Linux
+      - ubuntu-latest
     steps:
       - if: startsWith(runner.name, 'GitHub Actions') || startsWith(runner.name, 'Hosted Agent')
         name: Installing wasm-pack

diff --git a/build/build/src/ci_gen/job.rs b/build/build/src/ci_gen/job.rs
@@ -1,3 +1,5 @@
+use core::panic;
+
 use crate::prelude::*;
 
 use crate::ci_gen::not_default_branch;
@@ -307,6 +309,10 @@ fn build_job_ensuring_cloud_tests_run_on_github(
     cloud_tests_enabled: bool,
 ) -> Job {
     if cloud_tests_enabled {
+        if target.0 != OS::Linux {
+            panic!("If the Cloud tests are enabled, they require GitHub hosted runner for Cloud auth, so they only run on Linux.");
+        }
+
         run_steps_builder.build_job(job_name, RunnerLabel::LinuxLatest)
     } else {
         run_steps_builder.build_job(job_name, target)
@@ -320,6 +326,9 @@ const GRAAL_EDITION_FOR_EXTRA_TESTS: graalvm::Edition = graalvm::Edition::Commun
 
 impl JobArchetype for SnowflakeTests {
     fn job(&self, target: Target) -> Job {
+        if target.0 != OS::Linux {
+            panic!("Snowflake tests currently require GitHub hosted runner for Cloud auth, so they only run on Linux.");
+        }
         let job_name = "Snowflake Tests";
         let mut job = RunStepsBuilder::new("backend test std-snowflake")
             .customize(move |step| {
@@ -358,7 +367,7 @@ impl JobArchetype for SnowflakeTests {
                     step::extra_stdlib_test_reporter(target, GRAAL_EDITION_FOR_EXTRA_TESTS),
                 ]
             })
-            .build_job(job_name, target)
+            .build_job(job_name, RunnerLabel::LinuxLatest)
             .with_permission(Permission::Checks, Access::Write);
         job.env(env::GRAAL_EDITION, GRAAL_EDITION_FOR_EXTRA_TESTS);
         job