You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I guess I have to start questioning the basics. Why do we have Runtime.current_execution_environment? When I look at the usages, I don't see any reason why such a method should exist:
if I managed to remove this method
then environment argument would have to go away as well
environment argument
I am questioning the environment argument of the Context.is_enabled method
we don't use it anywhere
what does it suppose to mean?
If Runtime.current_execution_environment can be removed, then we can remove also environment argument.
Environment vs. Contexts
My view of the system:
various Runtime.Context instances (Input, Output, etc.) are the key concept
environment is just a "human friendly name" for a set of Runtime.Context instances
environment is used from CLI (as an argument)
environment is used from GUI (as a button)
but:
before passed to engine it is converted to set of RuntimeContext instances
engine, libs code only works with Context.Xyz.is_enabled & co. methods
never need to know anything about the "human friendly names" of sets of Runtime.Context instances
The implementation of #1173 is currently changing (the name of) the current environment. Now I believe that is not correct...
Guessing Dmitry did that to enable running a single node with Write enabled (a very nice feature)
... rather than changing the environment (e.g. human friendly name of set of Runtime.Context enabled instances) the language server should turn on Runtime.Context.Output - e.g. temporarily calls Context.Output.with_enabled before evaluating the given node.
I believe it would look the same from user perspective and would be less braided internally than what we have right now.
The text was updated successfully, but these errors were encountered:
Trying to replace the current
EnsoContext.getExecutionEnvironment
with a solution based onState
as described at #12294 reveals some issues.According to the specification @jdunkerley wants to achieve:
current_execution_environment
I guess I have to start questioning the basics. Why do we have
Runtime.current_execution_environment
? When I look at the usages, I don't see any reason why such a method should exist:environment
argument would have to go away as wellenvironment argument
I am questioning the
environment
argument of theContext.is_enabled
methodIf
Runtime.current_execution_environment
can be removed, then we can remove alsoenvironment
argument.Environment vs. Contexts
My view of the system:
Runtime.Context
instances (Input
,Output
, etc.) are the key conceptRuntime.Context
instancesRuntimeContext
instancesContext.Xyz.is_enabled
& co. methodsRuntime.Context
instancesThe implementation of #1173 is currently changing (the name of) the current environment. Now I believe that is not correct...
... rather than changing the environment (e.g. human friendly name of set of
Runtime.Context
enabled instances) the language server should turn onRuntime.Context.Output
- e.g. temporarily callsContext.Output.with_enabled
before evaluating the given node.I believe it would look the same from user perspective and would be less braided internally than what we have right now.
The text was updated successfully, but these errors were encountered: