Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a dropdown is open Escape should close the dropdown and Enter should still add a new node. #7477

Closed
jdunkerley opened this issue Aug 2, 2023 · 1 comment · Fixed by #9206
Closed

When a dropdown is open Escape should close the dropdown and Enter should still add a new node. #7477

jdunkerley opened this issue Aug 2, 2023 · 1 comment · Fixed by #9206
Assignees
@kazcw
Labels
-gui d-easy Difficulty: little prior knowledge required p-lowest Should be completed at some point x-new-feature Type: new feature request

Comments

@jdunkerley
Copy link
Member

If dropdown widget is open can use cursor keys.

Escape should close the dropdown.
Enter should still add a new now and close dropdown.
@jdunkerley jdunkerley added --bug Type: bug -gui labels Aug 2, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Aug 2, 2023
@farmaazon farmaazon added x-new-feature Type: new feature request d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints and removed --bug Type: bug labels Aug 7, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Aug 10, 2023
@jdunkerley jdunkerley added p-lowest Should be completed at some point and removed p-medium Should be completed in the next few sprints labels Sep 11, 2023
@farmaazon
Copy link
Contributor

Partially fixed in GUI2 - ESC does not close drop down, but enter works properly.

@farmaazon farmaazon added -gui and removed -gui labels Feb 27, 2024
@kazcw kazcw self-assigned this Feb 28, 2024
@kazcw kazcw moved this from 📤 Backlog to 👁️ Code review in Issues Board Feb 28, 2024
@kazcw kazcw linked a pull request Feb 28, 2024 that will close this issue
Close dropdowns #9206
Merged
5 tasks
@mergify mergify bot closed this as completed in #9206 Mar 1, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
-gui d-easy Difficulty: little prior knowledge required p-lowest Should be completed at some point x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close dropdowns enso-org/enso
3 participants
@kazcw @farmaazon @jdunkerley