Implement the improved Lucas test from Baillie et al '21 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 98.71% 98.85% +0.14%
==========================================
Files 11 11
Lines 1709 1744 +35
==========================================
+ Hits 1687 1724 +37
+ Misses 22 20 -2 ☔ View full report in Codecov by Sentry. |
fjarri
force-pushed
the
bpsw21
branch
3 times, most recently
from
5ef4b2d to
530bbb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
LucasCheck::Bpsw21implementing the checks described in Baillie et alis_prime_with_rng()andis_safe_prime_with_rng(), since the new check is deterministic.