Prefer core::num::NonZero over crypto_bigint::NonZero where possible #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to address #56 to the extent possible.
TL;DR is that we must use
crypto_bigint::NonZero
for all non-primitive types.This PR just makes it explicit which variant we're using by renaming the type to
CTNonZero
and prefers core'sNonZero
wherever possible.Given that
ZeroablePrimitive
is not on the path to stabilization any time soon, I suggest this closes #56.