ensure ID matches fname

Author: epwalsh

CHANGELOG.md

@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed `:ObsidianFollowLink` not creating a new note when following a dangling link; matches behavior in the official Obsidian app.
 - Fixed handling spaces in configured vault directory.
 - Fixed `:ObsidianFollowLink` not considering the vault's root directory.
+- Fixed bug where the note ID in the YAML frontmatter wasn't updated after the file is renamed.
 
 ### Changed
 

lua/obsidian/note.lua

@@ -158,7 +158,6 @@ end
 ---@return obsidian.Note
 note.from_lines = function(lines, path, root)
   local cwd = tostring(root and root or "./")
-  local relative_path = tostring(Path:new(tostring(path)):make_relative(cwd))
 
   local id = nil
   local title = nil
@@ -249,9 +248,13 @@ note.from_lines = function(lines, path, root)
     table.insert(aliases, title)
   end
 
-  -- Fall back to using the relative path as the ID.
-  if id == nil then
-    id = relative_path
+  -- The ID should match the filename with or without the extension.
+  local relative_path = tostring(Path:new(tostring(path)):make_relative(cwd))
+  local relative_path_no_ext = vim.fn.fnamemodify(relative_path, ":r")
+  local fname = vim.fs.basename(relative_path)
+  local fname_no_ext = vim.fn.fnamemodify(fname, ":r")
+  if id ~= relative_path and id ~= relative_path_no_ext and id ~= fname and id ~= fname_no_ext then
+    id = fname_no_ext
   end
 
   local n = note.new(id, aliases, tags, path)