Workaround crash with GCC 12 (#539)

When co_await and lambda with captures are used in the same expression, GCC 12 bug causes double free.
Use another runOnThreadPool overload that takes Args... which creates lambda outside of coroutine, so that this bug is not triggered.

Author: equeim

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [Unreleased]
 ### Fixed
 - Black screen issues when closing fullscreen window on macOS
+- Crash with GCC 12
 
 ## [2.7.2] - 2024-09-15
 ### Fixed

src/rpc/requestrouter.cpp

@@ -330,8 +330,8 @@ namespace tremotesf::impl {
     RequestRouter::onRequestSuccess(NetworkReplyUniquePtr reply, RpcRequestMetadata metadata) {
         debug()
             .log("HTTP request for method '{}' succeeded, HTTP status: {}", metadata.method, httpStatus(reply.get()));
-        const auto json =
-            co_await runOnThreadPool(mThreadPool, [reply = std::move(reply)]() -> std::optional<QJsonObject> {
+        const auto json = co_await runOnThreadPool(
+            [](NetworkReplyUniquePtr reply) -> std::optional<QJsonObject> {
                 const auto replyData = reply->readAll();
                 QJsonParseError error{};
                 QJsonObject json = QJsonDocument::fromJson(replyData, &error).object();
@@ -345,7 +345,9 @@ namespace tremotesf::impl {
                     return {};
                 }
                 return json;
-            });
+            },
+            std::move(reply)
+        );
         if (!json.has_value()) {
             emit requestFailed(RpcError::ParseError, {}, {});
             cancelCoroutine();

src/ui/screens/torrentproperties/torrentfilesmodel.cpp

@@ -206,10 +206,10 @@ namespace tremotesf {
         mCreatingTree = true;
         beginResetModel();
 
-        auto self = QPointer(this);
-
-        auto [rootDirectory, files] =
-            co_await runOnThreadPool([files = std::vector(mTorrent->files())]() { return doCreateTree(files); });
+        auto [rootDirectory, files] = co_await runOnThreadPool(
+            [](const std::vector<TorrentFile>& files) { return doCreateTree(files); },
+            mTorrent->files()
+        );
 
         mRootDirectory = std::move(rootDirectory);
         endResetModel();