Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better contrast icons in torrent list #278

Open
Pentaphon opened this issue Feb 23, 2023 · 3 comments
Open

Better contrast icons in torrent list #278

Pentaphon opened this issue Feb 23, 2023 · 3 comments

Comments

@Pentaphon
Copy link

Pentaphon commented Feb 23, 2023

icon
Currently, the seeding icon is a low-contrast icon on the light and dark modes. It's hard to tell what it is even is in either mode.

Perhaps a simpler, high contrast set of icons can be used to show the current state?

@Pentaphon Pentaphon changed the title Always show available free space on main window Better contrast icons in torrent list Feb 23, 2023
@equeim
Copy link
Owner

equeim commented Mar 15, 2023

Hmm. The idea is to differentiate between torrents that are being actively downloaded/uploaded from those that are just sitting there. I'm not sure how beneficial is this, but I find this useful.

I'm not sure I have enough skill to make a new ones (I just stole them (legally) from old version of qBittorrent in the first place). Maybe making arrow brighter will improve this (I might as well remake them in svg, it's needed for hidpi).

@Teloriun
Copy link

Reading this gave me some flashbacks to uTorrent where you could download and replace the status and toolbar icons with your own creations (maybe a bit dated having them in .bmp but worked well). Don't know if something like this would work, then if people don't like the provided version, they could use their own?

image

toolbar
image
torrentstatus
image

equeim added a commit that referenced this issue Mar 23, 2023
Also fix hidpi issues with them by using SVG and QIcon instead of QPixmap.
equeim added a commit that referenced this issue Mar 23, 2023
Also fix hidpi issues with them by using SVG and QIcon instead of QPixmap.
equeim added a commit that referenced this issue Mar 23, 2023
Also fix hidpi issues with them by using SVG and QIcon instead of QPixmap.
equeim added a commit that referenced this issue Mar 25, 2023
Also fix hidpi issues with them by using SVG and QIcon instead of QPixmap.
@Pentaphon
Copy link
Author

Pentaphon commented Apr 7, 2023

@equeim huge improvement with that commit but I have to say the "active" icon still has a contrast issue where it's green on purple and it just doesn't look as good as the other icons. Do you think you can find a better icon for "active"? Maybe the green play button should have a green outline similar to the "downloading" icon? The purple really conflicts with the green and that's the only purple you see in the entire application.

55272ad#diff-cf7cde5286b65baf8a282b83a7ccf0b8003e3693f72da6c796209315cc673330

This is the icon I think needs to be changed. The green on purple really doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants