New inspections view #1880
Merged
New inspections view #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrica-equinor
force-pushed
the
new-inspections-view
branch
2 times, most recently
from
25b9326 to
a63fa6f
Compare
mrica-equinor
added
feature
mrica-equinor
force-pushed
the
new-inspections-view
branch
from
a63fa6f to
e106fe2
Compare
tsundvoll
reviewed
Dec 13, 2024
Comment on lines
+74
to
+79
| try | ||
| { | ||
| inspection = await inspectionService.ReadByIsarTaskId(taskId, readOnly: true); | ||
| if (inspection == null) return NotFound($"Could not find inspection for task with Id {taskId}."); | ||
|
|
||
| } |
There was a problem hiding this comment.
Consider querying the inspection by the inspectionID instead of the taskID
tsundvoll
reviewed
Dec 13, 2024
|
|
||
| if (!inspectionData.BlobContainer.ToLower(CultureInfo.CurrentCulture).Equals(installationCode.ToLower(CultureInfo.CurrentCulture), StringComparison.Ordinal)) | ||
| { | ||
| return NotFound($"Could not find inspection data for inspection with Id {inspection.Id} because blob name {inspectionData.BlobName} does not match installation {installationCode}."); |
There was a problem hiding this comment.
Consider moving the checks into the InspectionService
tsundvoll
reviewed
Dec 13, 2024
tsundvoll
reviewed
Dec 13, 2024
tsundvoll
reviewed
Dec 13, 2024
tsundvoll
reviewed
Dec 13, 2024
| @@ -430,4 +430,12 @@ export class BackendAPICaller { | |||
| }) | |||
| return result.content | |||
| } | |||
|
|
|||
| static async getInspection(installationCode: string, taskId: string): Promise<Blob> { | |||
| const path: string = 'inspection/' + installationCode + '/' + taskId + '/taskId' | |||
There was a problem hiding this comment.
Consider querying by inspectionId instead of taskId
tsundvoll
reviewed
Dec 13, 2024
Comment on lines
+69
to
+71
| .catch(() => { | ||
| setStartTimer((oldValue) => !oldValue) | ||
| }) |
There was a problem hiding this comment.
Consider stop trying if we get a failed workflow from the backend
tsundvoll
reviewed
Dec 13, 2024
| <Typography key={task.id + task.inspection.id + 'insp'} link href={task.inspection.inspectionUrl}> | ||
| {TranslateText(task.inspection.inspectionType as string)} | ||
| </Typography> | ||
| (task.inspection.inspectionType === InspectionType.Image ? ( |
There was a problem hiding this comment.
In the future we can also do this for ThermalImage
tsundvoll
approved these changes
Dec 13, 2024
mrica-equinor
force-pushed
the
new-inspections-view
branch
from
e106fe2 to
be43143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review checklist: