Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra check about existing and new $contractual #1009

Open
mferrera opened this issue Feb 18, 2025 · 0 comments
Open

Add extra check about existing and new $contractual #1009

mferrera opened this issue Feb 18, 2025 · 0 comments

Comments

@mferrera
Copy link
Collaborator

Removing a contractual item should be an exceptionally rare occurrence. We should add an additional check around the contractual items.

If existing contractual is not a subset of the new contractual:

  • It should flag and warn, at minimum, from update-schemas.
    • Maybe this requires an additional flag to force, like --force-contractual (in addition to existing --force)
  • A test should fail (?) (this may not be practical for CI)
@mferrera mferrera added simple-exports-milestone Relevant to the current milestone and removed simple-exports-milestone Relevant to the current milestone labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant