forked from kubernetes/test-infra
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathlgtm_test.go
1411 lines (1365 loc) · 38.4 KB
/
lgtm_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Copyright 2016 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package lgtm
import (
"fmt"
"io/ioutil"
"path/filepath"
"regexp"
"strings"
"testing"
"time"
"github.com/sirupsen/logrus"
"sigs.k8s.io/yaml"
"k8s.io/apimachinery/pkg/api/equality"
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/test-infra/prow/config"
"k8s.io/test-infra/prow/github"
"k8s.io/test-infra/prow/github/fakegithub"
"k8s.io/test-infra/prow/pkg/layeredsets"
"k8s.io/test-infra/prow/plugins"
"k8s.io/test-infra/prow/plugins/ownersconfig"
"k8s.io/test-infra/prow/repoowners"
)
type fakeOwnersClient struct {
approvers map[string]layeredsets.String
reviewers map[string]layeredsets.String
}
func (f *fakeOwnersClient) LoadRepoOwnersSha(org, repo, base, sha string, updateCache bool) (repoowners.RepoOwner, error) {
return &fakeRepoOwners{approvers: f.approvers, reviewers: f.reviewers}, nil
}
var _ repoowners.Interface = &fakeOwnersClient{}
func (f *fakeOwnersClient) LoadRepoOwners(org, repo, base string) (repoowners.RepoOwner, error) {
return &fakeRepoOwners{approvers: f.approvers, reviewers: f.reviewers}, nil
}
func (f *fakeOwnersClient) WithFields(fields logrus.Fields) repoowners.Interface {
return f
}
func (f *fakeOwnersClient) WithGitHubClient(client github.Client) repoowners.Interface {
return f
}
func (f *fakeOwnersClient) ForPlugin(string) repoowners.Interface {
return f
}
func (f *fakeOwnersClient) Used() bool {
return true
}
type fakeRepoOwners struct {
approvers map[string]layeredsets.String
reviewers map[string]layeredsets.String
dirDenylist []*regexp.Regexp
}
func (f *fakeRepoOwners) AllOwners() sets.String {
return sets.String{}
}
func (f *fakeRepoOwners) Filenames() ownersconfig.Filenames {
return ownersconfig.FakeFilenames
}
type fakePruner struct {
GitHubClient *fakegithub.FakeClient
IssueComments []github.IssueComment
}
func (fp *fakePruner) PruneComments(shouldPrune func(github.IssueComment) bool) {
for _, comment := range fp.IssueComments {
if shouldPrune(comment) {
fp.GitHubClient.IssueCommentsDeleted = append(fp.GitHubClient.IssueCommentsDeleted, comment.Body)
}
}
}
var _ repoowners.RepoOwner = &fakeRepoOwners{}
func (f *fakeRepoOwners) FindApproverOwnersForFile(path string) string { return "" }
func (f *fakeRepoOwners) FindReviewersOwnersForFile(path string) string { return "" }
func (f *fakeRepoOwners) FindLabelsForFile(path string) sets.String { return nil }
func (f *fakeRepoOwners) IsNoParentOwners(path string) bool { return false }
func (f *fakeRepoOwners) IsAutoApproveUnownedSubfolders(path string) bool { return false }
func (f *fakeRepoOwners) LeafApprovers(path string) sets.String { return nil }
func (f *fakeRepoOwners) Approvers(path string) layeredsets.String { return f.approvers[path] }
func (f *fakeRepoOwners) LeafReviewers(path string) sets.String { return nil }
func (f *fakeRepoOwners) Reviewers(path string) layeredsets.String { return f.reviewers[path] }
func (f *fakeRepoOwners) RequiredReviewers(path string) sets.String { return nil }
func (f *fakeRepoOwners) TopLevelApprovers() sets.String { return nil }
func (f *fakeRepoOwners) ParseSimpleConfig(path string) (repoowners.SimpleConfig, error) {
dir := filepath.Dir(path)
for _, re := range f.dirDenylist {
if re.MatchString(dir) {
return repoowners.SimpleConfig{}, filepath.SkipDir
}
}
b, err := ioutil.ReadFile(path)
if err != nil {
return repoowners.SimpleConfig{}, err
}
full := new(repoowners.SimpleConfig)
err = yaml.Unmarshal(b, full)
return *full, err
}
func (f *fakeRepoOwners) ParseFullConfig(path string) (repoowners.FullConfig, error) {
dir := filepath.Dir(path)
for _, re := range f.dirDenylist {
if re.MatchString(dir) {
return repoowners.FullConfig{}, filepath.SkipDir
}
}
b, err := ioutil.ReadFile(path)
if err != nil {
return repoowners.FullConfig{}, err
}
full := new(repoowners.FullConfig)
err = yaml.Unmarshal(b, full)
return *full, err
}
var approvers = map[string]layeredsets.String{
"doc/README.md": layeredsets.NewString("cjwagner", "jessica"),
}
var reviewers = map[string]layeredsets.String{
"doc/README.md": layeredsets.NewString("alice", "bob", "mark", "sam"),
}
func TestLGTMComment(t *testing.T) {
var testcases = []struct {
name string
body string
commenter string
hasLGTM bool
shouldToggle bool
shouldComment bool
shouldAssign bool
skipCollab bool
storeTreeHash bool
shouldRequest bool
}{
{
name: "non-lgtm comment",
body: "uh oh",
commenter: "collab2",
hasLGTM: false,
shouldToggle: false,
},
{
name: "lgtm comment by reviewer, no lgtm on pr",
body: "/lgtm",
commenter: "collab1",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
},
{
name: "LGTM comment by reviewer, no lgtm on pr",
body: "/LGTM",
commenter: "collab1",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
},
{
name: "lgtm comment by reviewer, lgtm on pr",
body: "/lgtm",
commenter: "collab1",
hasLGTM: true,
shouldToggle: false,
},
{
name: "lgtm comment by author",
body: "/lgtm",
commenter: "author",
hasLGTM: false,
shouldToggle: false,
shouldComment: true,
},
{
name: "lgtm cancel by author",
body: "/lgtm cancel",
commenter: "author",
hasLGTM: true,
shouldToggle: true,
shouldAssign: false,
shouldComment: false,
shouldRequest: true,
},
{
name: "remove lgtm by author",
body: "/remove-lgtm",
commenter: "author",
hasLGTM: true,
shouldToggle: true,
shouldAssign: false,
shouldComment: false,
shouldRequest: true,
},
{
name: "lgtm comment by non-reviewer",
body: "/lgtm",
commenter: "collab2",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
shouldAssign: true,
},
{
name: "lgtm comment by non-reviewer, with trailing space",
body: "/lgtm ",
commenter: "collab2",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
shouldAssign: true,
},
{
name: "lgtm comment by non-reviewer, with no-issue",
body: "/lgtm no-issue",
commenter: "collab2",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
shouldAssign: true,
},
{
name: "lgtm comment by non-reviewer, with no-issue and trailing space",
body: "/lgtm no-issue \r",
commenter: "collab2",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
shouldAssign: true,
},
{
name: "lgtm comment by rando",
body: "/lgtm",
commenter: "not-in-the-org",
hasLGTM: false,
shouldToggle: false,
shouldComment: true,
shouldAssign: false,
},
{
name: "lgtm cancel by non-reviewer",
body: "/lgtm cancel",
commenter: "collab2",
hasLGTM: true,
shouldToggle: true,
shouldComment: false,
shouldAssign: true,
shouldRequest: true,
},
{
name: "remove lgtm by non-reviewer",
body: "/remove-lgtm",
commenter: "collab2",
hasLGTM: true,
shouldToggle: true,
shouldComment: false,
shouldAssign: true,
shouldRequest: true,
},
{
name: "lgtm cancel by rando",
body: "/lgtm cancel",
commenter: "not-in-the-org",
hasLGTM: true,
shouldToggle: false,
shouldComment: true,
shouldAssign: false,
},
{
name: "remove lgtm by rando",
body: "/remove-lgtm",
commenter: "not-in-the-org",
hasLGTM: true,
shouldToggle: false,
shouldComment: true,
shouldAssign: false,
},
{
name: "lgtm cancel comment by reviewer",
body: "/lgtm cancel",
commenter: "collab1",
hasLGTM: true,
shouldToggle: true,
shouldRequest: true,
},
{
name: "remove-lgtm comment by reviewer",
body: "/remove-lgtm",
commenter: "collab1",
hasLGTM: true,
shouldToggle: true,
shouldRequest: true,
},
{
name: "lgtm cancel comment by reviewer, with trailing space",
body: "/lgtm cancel \r",
commenter: "collab1",
hasLGTM: true,
shouldToggle: true,
shouldRequest: true,
},
{
name: "remove lgtm comment by reviewer, with trailing space",
body: "/remove-lgtm \r",
commenter: "collab1",
hasLGTM: true,
shouldToggle: true,
shouldRequest: true,
},
{
name: "lgtm cancel comment by reviewer, no lgtm",
body: "/lgtm cancel",
commenter: "collab1",
hasLGTM: false,
shouldToggle: false,
},
{
name: "remove lgtm comment by reviewer, no lgtm",
body: "/remove-lgtm",
commenter: "collab1",
hasLGTM: false,
shouldToggle: false,
},
{
name: "lgtm comment, based off OWNERS only",
body: "/lgtm",
commenter: "sam",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
skipCollab: true,
},
{
name: "lgtm comment by assignee, but not collab",
body: "/lgtm",
commenter: "assignee1",
hasLGTM: false,
shouldToggle: false,
shouldComment: true,
shouldAssign: false,
},
}
SHA := "0bd3ed50c88cd53a09316bf7a298f900e9371652"
for _, tc := range testcases {
t.Logf("Running scenario %q", tc.name)
fc := fakegithub.NewFakeClient()
fc.IssueComments = make(map[int][]github.IssueComment)
fc.PullRequests = map[int]*github.PullRequest{
5: {
Base: github.PullRequestBranch{
Ref: "master",
},
Head: github.PullRequestBranch{
SHA: SHA,
},
},
}
fc.PullRequestChanges = map[int][]github.PullRequestChange{
5: {
{Filename: "doc/README.md"},
},
}
fc.Collaborators = []string{"collab1", "collab2"}
e := &github.GenericCommentEvent{
Action: github.GenericCommentActionCreated,
IssueState: "open",
IsPR: true,
Body: tc.body,
User: github.User{Login: tc.commenter},
IssueAuthor: github.User{Login: "author"},
Number: 5,
Assignees: []github.User{{Login: "collab1"}, {Login: "assignee1"}},
Repo: github.Repo{Owner: github.User{Login: "org"}, Name: "repo"},
HTMLURL: "<url>",
}
if tc.hasLGTM {
fc.IssueLabelsAdded = []string{"org/repo#5:" + LGTMLabel}
}
oc := &fakeOwnersClient{approvers: approvers, reviewers: reviewers}
pc := &plugins.Configuration{}
if tc.skipCollab {
pc.Owners.SkipCollaborators = []string{"org/repo"}
}
pc.Lgtm = append(pc.Lgtm, plugins.Lgtm{
Repos: []string{"org/repo"},
StoreTreeHash: true,
})
fp := &fakePruner{
GitHubClient: fc,
IssueComments: fc.IssueComments[5],
}
if err := handleGenericComment(fc, pc, oc, logrus.WithField("plugin", PluginName), fp, *e); err != nil {
t.Errorf("didn't expect error from lgtmComment: %v", err)
continue
}
if tc.shouldAssign {
found := false
for _, a := range fc.AssigneesAdded {
if a == fmt.Sprintf("%s/%s#%d:%s", "org", "repo", 5, tc.commenter) {
found = true
break
}
}
if !found || len(fc.AssigneesAdded) != 1 {
t.Errorf("should have assigned %s but added assignees are %s", tc.commenter, fc.AssigneesAdded)
}
} else if len(fc.AssigneesAdded) != 0 {
t.Errorf("should not have assigned anyone but assigned %s", fc.AssigneesAdded)
}
if tc.shouldToggle {
if tc.hasLGTM {
if len(fc.IssueLabelsRemoved) == 0 {
t.Error("should have removed LGTM.")
} else if len(fc.IssueLabelsAdded) > 1 {
t.Error("should not have added LGTM.")
}
} else {
if len(fc.IssueLabelsAdded) == 0 {
t.Error("should have added LGTM.")
} else if len(fc.IssueLabelsRemoved) > 0 {
t.Error("should not have removed LGTM.")
}
}
} else if len(fc.IssueLabelsRemoved) > 0 {
t.Error("should not have removed LGTM.")
} else if (tc.hasLGTM && len(fc.IssueLabelsAdded) > 1) || (!tc.hasLGTM && len(fc.IssueLabelsAdded) > 0) {
t.Error("should not have added LGTM.")
}
if tc.shouldComment && len(fc.IssueComments[5]) != 1 {
t.Error("should have commented.")
} else if !tc.shouldComment && len(fc.IssueComments[5]) != 0 {
t.Error("should not have commented.")
}
if tc.shouldRequest && len(fc.ReviewersRequested) == 0 {
t.Error("should have re-requested reviewers")
}
if !tc.shouldRequest && len(fc.ReviewersRequested) > 0 {
t.Errorf("should not have re-requested reviewers, but requested these reviewers %v", fc.ReviewersRequested)
}
}
}
func TestLGTMCommentWithLGTMNoti(t *testing.T) {
var testcases = []struct {
name string
body string
commenter string
shouldDelete bool
}{
{
name: "non-lgtm comment",
body: "uh oh",
commenter: "collab2",
shouldDelete: false,
},
{
name: "lgtm comment by reviewer, no lgtm on pr",
body: "/lgtm",
commenter: "collab1",
shouldDelete: true,
},
{
name: "LGTM comment by reviewer, no lgtm on pr",
body: "/LGTM",
commenter: "collab1",
shouldDelete: true,
},
{
name: "lgtm comment by author",
body: "/lgtm",
commenter: "author",
shouldDelete: false,
},
{
name: "lgtm comment by non-reviewer",
body: "/lgtm",
commenter: "collab2",
shouldDelete: true,
},
{
name: "lgtm comment by non-reviewer, with trailing space",
body: "/lgtm ",
commenter: "collab2",
shouldDelete: true,
},
{
name: "lgtm comment by non-reviewer, with no-issue",
body: "/lgtm no-issue",
commenter: "collab2",
shouldDelete: true,
},
{
name: "lgtm comment by non-reviewer, with no-issue and trailing space",
body: "/lgtm no-issue \r",
commenter: "collab2",
shouldDelete: true,
},
{
name: "lgtm comment by rando",
body: "/lgtm",
commenter: "not-in-the-org",
shouldDelete: false,
},
{
name: "lgtm cancel comment by reviewer, no lgtm",
body: "/lgtm cancel",
commenter: "collab1",
shouldDelete: false,
},
{
name: "remove-lgtm comment by reviewer, no lgtm",
body: "/remove-lgtm",
commenter: "collab1",
shouldDelete: false,
},
}
SHA := "0bd3ed50c88cd53a09316bf7a298f900e9371652"
for _, tc := range testcases {
fc := fakegithub.NewFakeClient()
fc.IssueComments = make(map[int][]github.IssueComment)
fc.PullRequests = map[int]*github.PullRequest{
5: {
Head: github.PullRequestBranch{
SHA: SHA,
},
},
}
fc.Collaborators = []string{"collab1", "collab2"}
e := &github.GenericCommentEvent{
Action: github.GenericCommentActionCreated,
IssueState: "open",
IsPR: true,
Body: tc.body,
User: github.User{Login: tc.commenter},
IssueAuthor: github.User{Login: "author"},
Number: 5,
Assignees: []github.User{{Login: "collab1"}, {Login: "assignee1"}},
Repo: github.Repo{Owner: github.User{Login: "org"}, Name: "repo"},
HTMLURL: "<url>",
}
botUser, err := fc.BotUser()
if err != nil {
t.Fatalf("For case %s, could not get Bot nam", tc.name)
}
ic := github.IssueComment{
User: github.User{
Login: botUser.Login,
},
Body: removeLGTMLabelNoti,
}
fc.IssueComments[5] = append(fc.IssueComments[5], ic)
oc := &fakeOwnersClient{approvers: approvers, reviewers: reviewers}
pc := &plugins.Configuration{}
fp := &fakePruner{
GitHubClient: fc,
IssueComments: fc.IssueComments[5],
}
if err := handleGenericComment(fc, pc, oc, logrus.WithField("plugin", PluginName), fp, *e); err != nil {
t.Errorf("For case %s, didn't expect error from lgtmComment: %v", tc.name, err)
continue
}
deleted := false
for _, body := range fc.IssueCommentsDeleted {
if body == removeLGTMLabelNoti {
deleted = true
break
}
}
if tc.shouldDelete {
if !deleted {
t.Errorf("For case %s, LGTM removed notification should have been deleted", tc.name)
}
} else {
if deleted {
t.Errorf("For case %s, LGTM removed notification should not have been deleted", tc.name)
}
}
}
}
func TestLGTMFromApproveReview(t *testing.T) {
var testcases = []struct {
name string
state github.ReviewState
action github.ReviewEventAction
body string
reviewer string
hasLGTM bool
shouldToggle bool
shouldComment bool
shouldAssign bool
storeTreeHash bool
}{
{
name: "Edit approve review by reviewer, no lgtm on pr",
state: github.ReviewStateApproved,
action: github.ReviewActionEdited,
reviewer: "collab1",
hasLGTM: false,
shouldToggle: false,
storeTreeHash: true,
},
{
name: "Dismiss approve review by reviewer, no lgtm on pr",
state: github.ReviewStateApproved,
action: github.ReviewActionDismissed,
reviewer: "collab1",
hasLGTM: false,
shouldToggle: false,
storeTreeHash: true,
},
{
name: "Request changes review by reviewer, no lgtm on pr",
state: github.ReviewStateChangesRequested,
action: github.ReviewActionSubmitted,
reviewer: "collab1",
hasLGTM: false,
shouldToggle: false,
shouldAssign: false,
shouldComment: false,
},
{
name: "Request changes review by reviewer, lgtm on pr",
state: github.ReviewStateChangesRequested,
action: github.ReviewActionSubmitted,
reviewer: "collab1",
hasLGTM: true,
shouldToggle: true,
shouldAssign: false,
},
{
name: "Approve review by reviewer, no lgtm on pr",
state: github.ReviewStateApproved,
action: github.ReviewActionSubmitted,
reviewer: "collab1",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
storeTreeHash: true,
},
{
name: "Approve review by reviewer, no lgtm on pr, do not store tree_hash",
state: github.ReviewStateApproved,
action: github.ReviewActionSubmitted,
reviewer: "collab1",
hasLGTM: false,
shouldToggle: true,
shouldComment: false,
},
{
name: "Approve review by reviewer, lgtm on pr",
state: github.ReviewStateApproved,
action: github.ReviewActionSubmitted,
reviewer: "collab1",
hasLGTM: true,
shouldToggle: false,
shouldAssign: false,
},
{
name: "Approve review by non-reviewer, no lgtm on pr",
state: github.ReviewStateApproved,
action: github.ReviewActionSubmitted,
reviewer: "collab2",
hasLGTM: false,
shouldToggle: true,
shouldComment: true,
shouldAssign: true,
storeTreeHash: true,
},
{
name: "Request changes review by non-reviewer, no lgtm on pr",
state: github.ReviewStateChangesRequested,
action: github.ReviewActionSubmitted,
reviewer: "collab2",
hasLGTM: false,
shouldToggle: false,
shouldComment: false,
shouldAssign: true,
},
{
name: "Approve review by rando",
state: github.ReviewStateApproved,
action: github.ReviewActionSubmitted,
reviewer: "not-in-the-org",
hasLGTM: false,
shouldToggle: false,
shouldComment: true,
shouldAssign: false,
},
{
name: "Comment review by issue author, no lgtm on pr",
state: github.ReviewStateCommented,
action: github.ReviewActionSubmitted,
reviewer: "author",
hasLGTM: false,
shouldToggle: false,
shouldComment: false,
shouldAssign: false,
},
{
name: "Comment body has /lgtm on Comment Review ",
state: github.ReviewStateCommented,
action: github.ReviewActionSubmitted,
reviewer: "collab1",
body: "/lgtm",
hasLGTM: false,
shouldToggle: false,
shouldComment: false,
shouldAssign: false,
},
{
name: "Comment body has /lgtm cancel on Approve Review",
state: github.ReviewStateApproved,
action: github.ReviewActionSubmitted,
reviewer: "collab1",
body: "/lgtm cancel",
hasLGTM: false,
shouldToggle: false,
shouldComment: false,
shouldAssign: false,
},
}
SHA := "0bd3ed50c88cd53a09316bf7a298f900e9371652"
for _, tc := range testcases {
fc := fakegithub.NewFakeClient()
fc.IssueComments = make(map[int][]github.IssueComment)
fc.IssueLabelsAdded = []string{}
fc.PullRequests = map[int]*github.PullRequest{
5: {
Head: github.PullRequestBranch{
SHA: SHA,
},
},
}
fc.Collaborators = []string{"collab1", "collab2"}
e := &github.ReviewEvent{
Action: tc.action,
Review: github.Review{Body: tc.body, State: tc.state, HTMLURL: "<url>", User: github.User{Login: tc.reviewer}},
PullRequest: github.PullRequest{User: github.User{Login: "author"}, Assignees: []github.User{{Login: "collab1"}, {Login: "assignee1"}}, Number: 5},
Repo: github.Repo{Owner: github.User{Login: "org"}, Name: "repo"},
}
if tc.hasLGTM {
fc.IssueLabelsAdded = append(fc.IssueLabelsAdded, "org/repo#5:"+LGTMLabel)
}
oc := &fakeOwnersClient{approvers: approvers, reviewers: reviewers}
pc := &plugins.Configuration{}
pc.Lgtm = append(pc.Lgtm, plugins.Lgtm{
Repos: []string{"org/repo"},
StoreTreeHash: tc.storeTreeHash,
})
fp := &fakePruner{
GitHubClient: fc,
IssueComments: fc.IssueComments[5],
}
if err := handlePullRequestReview(fc, pc, oc, logrus.WithField("plugin", PluginName), fp, *e); err != nil {
t.Errorf("For case %s, didn't expect error from pull request review: %v", tc.name, err)
continue
}
if tc.shouldAssign {
found := false
for _, a := range fc.AssigneesAdded {
if a == fmt.Sprintf("%s/%s#%d:%s", "org", "repo", 5, tc.reviewer) {
found = true
break
}
}
if !found || len(fc.AssigneesAdded) != 1 {
t.Errorf("For case %s, should have assigned %s but added assignees are %s", tc.name, tc.reviewer, fc.AssigneesAdded)
}
} else if len(fc.AssigneesAdded) != 0 {
t.Errorf("For case %s, should not have assigned anyone but assigned %s", tc.name, fc.AssigneesAdded)
}
if tc.shouldToggle {
if tc.hasLGTM {
if len(fc.IssueLabelsRemoved) == 0 {
t.Errorf("For case %s, should have removed LGTM.", tc.name)
} else if len(fc.IssueLabelsAdded) > 1 {
t.Errorf("For case %s, should not have added LGTM.", tc.name)
}
} else {
if len(fc.IssueLabelsAdded) == 0 {
t.Errorf("For case %s, should have added LGTM.", tc.name)
} else if len(fc.IssueLabelsRemoved) > 0 {
t.Errorf("For case %s, should not have removed LGTM.", tc.name)
}
}
} else if len(fc.IssueLabelsRemoved) > 0 {
t.Errorf("For case %s, should not have removed LGTM.", tc.name)
} else if (tc.hasLGTM && len(fc.IssueLabelsAdded) > 1) || (!tc.hasLGTM && len(fc.IssueLabelsAdded) > 0) {
t.Errorf("For case %s, should not have added LGTM.", tc.name)
}
if tc.shouldComment && len(fc.IssueComments[5]) != 1 {
t.Errorf("For case %s, should have commented.", tc.name)
} else if !tc.shouldComment && len(fc.IssueComments[5]) != 0 {
t.Errorf("For case %s, should not have commented.", tc.name)
}
}
}
func TestHandlePullRequest(t *testing.T) {
SHA := "0bd3ed50c88cd53a09316bf7a298f900e9371652"
treeSHA := "6dcb09b5b57875f334f61aebed695e2e4193db5e"
cases := []struct {
name string
event github.PullRequestEvent
removeLabelErr error
createCommentErr error
err error
IssueLabelsAdded []string
IssueLabelsRemoved []string
issueComments map[int][]github.IssueComment
trustedTeam string
expectNoComments bool
shouldRequest bool
}{
{
name: "pr_synchronize, no RemoveLabel error",
event: github.PullRequestEvent{
Action: github.PullRequestActionSynchronize,
PullRequest: github.PullRequest{
Number: 101,
Base: github.PullRequestBranch{
Repo: github.Repo{
Owner: github.User{
Login: "kubernetes",
},
Name: "kubernetes",
},
},
Head: github.PullRequestBranch{
SHA: SHA,
},
Assignees: []github.User{
{
Login: "TestReviewer",
},
},
},
},
IssueLabelsRemoved: []string{LGTMLabel},
shouldRequest: true,
issueComments: map[int][]github.IssueComment{
101: {
{
Body: removeLGTMLabelNoti,
User: github.User{Login: fakegithub.Bot},
},
},
},
expectNoComments: false,
},
{
name: "Sticky LGTM for trusted team members",
event: github.PullRequestEvent{
Action: github.PullRequestActionSynchronize,
PullRequest: github.PullRequest{
Number: 101,
Base: github.PullRequestBranch{
Repo: github.Repo{
Owner: github.User{
Login: "kubernetes",
},
Name: "kubernetes",
},
},
User: github.User{
Login: "sig-lead",
},
MergeSHA: &SHA,
Assignees: []github.User{
{
Login: "TestReviewer",
},
},
},
},
trustedTeam: "Leads",
expectNoComments: true,
},
{
name: "LGTM not sticky for trusted user if disabled",
event: github.PullRequestEvent{
Action: github.PullRequestActionSynchronize,
PullRequest: github.PullRequest{
Number: 101,
Base: github.PullRequestBranch{
Repo: github.Repo{
Owner: github.User{
Login: "kubernetes",
},
Name: "kubernetes",
},
},
User: github.User{
Login: "sig-lead",
},
MergeSHA: &SHA,
Assignees: []github.User{
{
Login: "TestReviewer",
},
},
},
},
IssueLabelsRemoved: []string{LGTMLabel},
shouldRequest: true,
issueComments: map[int][]github.IssueComment{
101: {
{
Body: removeLGTMLabelNoti,
User: github.User{Login: fakegithub.Bot},
},
},
},
expectNoComments: false,
},
{
name: "LGTM not sticky for non trusted user",
event: github.PullRequestEvent{
Action: github.PullRequestActionSynchronize,
PullRequest: github.PullRequest{
Number: 101,
Base: github.PullRequestBranch{
Repo: github.Repo{
Owner: github.User{
Login: "kubernetes",
},
Name: "kubernetes",
},
},
User: github.User{
Login: "sig-lead",
},
MergeSHA: &SHA,
Assignees: []github.User{
{
Login: "TestReviewer",
},
},
},
},
IssueLabelsRemoved: []string{LGTMLabel},
shouldRequest: true,
issueComments: map[int][]github.IssueComment{
101: {
{
Body: removeLGTMLabelNoti,
User: github.User{Login: fakegithub.Bot},
},
},
},
trustedTeam: "Committers",
expectNoComments: false,
},
{
name: "pr_assigned",
event: github.PullRequestEvent{
Action: "assigned",
},
expectNoComments: true,
},
{
name: "pr_synchronize, same tree-hash, keep label",
event: github.PullRequestEvent{