Skip to content

Commit 905c751

Browse files
committed
Update UtilityTest.php
1 parent fa9b866 commit 905c751

File tree

1 file changed

+25
-66
lines changed

1 file changed

+25
-66
lines changed

tests/src/UtilityTest.php

Lines changed: 25 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -376,12 +376,9 @@ public function testRandomBytes(): void
376376
$bytes = Utility::randomBytes(8);
377377
$this->assertNotEmpty($bytes);
378378

379-
try {
380-
$this->expectException(\Random\RandomException::class);
381-
$bytes = Utility::randomBytes(0);
382-
} finally {
383-
//
384-
}
379+
$this->expectException(\Random\RandomException::class);
380+
$bytes = Utility::randomBytes(0);
381+
385382
}
386383

387384
/**
@@ -392,15 +389,11 @@ public function testRandomInt(): void
392389
$int = Utility::randomInt(100, 250);
393390
$this->assertTrue(($int >= 100 and $int <= 250));
394391

395-
try {
396-
$this->expectException(\Random\RandomException::class);
397-
$int = Utility::randomInt(intval(\PHP_INT_MIN - 1), \PHP_INT_MAX);
398392

399-
$this->expectException(\Random\RandomException::class);
400-
$int = Utility::randomInt(\PHP_INT_MAX, \PHP_INT_MIN);
401-
} finally {
402-
//
403-
}
393+
$this->expectException(\Random\RandomException::class);
394+
$int = Utility::randomInt(\intval(\PHP_INT_MIN - 1), \PHP_INT_MAX);
395+
$int = Utility::randomInt(\PHP_INT_MAX, \PHP_INT_MIN);
396+
404397
}
405398

406399
/**
@@ -411,12 +404,9 @@ public function testRandomString(): void
411404
$str = Utility::randomString(16);
412405
$this->assertTrue(Utility::length($str) === 16);
413406

414-
try {
415-
$this->expectException(\Random\RandomException::class);
416-
$str = Utility::randomString(-10);
417-
} finally {
418-
//
419-
}
407+
$this->expectException(\Random\RandomException::class);
408+
$str = Utility::randomString(-10);
409+
420410
}
421411

422412
/**
@@ -429,12 +419,8 @@ public function testLineCounter(): void
429419
$this->assertEquals(0, \array_sum(Utility::lineCounter(directory: self::$testDir, ignore: ['dir1'], onlyLineCount: true)));
430420
Utility::fileWrite(self::$testFiles['file1'], '');
431421

432-
try {
433-
$this->expectException(\InvalidArgumentException::class);
434-
$count = \array_sum(Utility::lineCounter('/this/should/not/exist', onlyLineCount: true));
435-
} finally {
436-
//
437-
}
422+
$this->expectException(\InvalidArgumentException::class);
423+
$count = \array_sum(Utility::lineCounter('/this/should/not/exist', onlyLineCount: true));
438424
}
439425

440426
/**
@@ -451,12 +437,8 @@ public function testDirectorySize(): void
451437
Utility::fileWrite(self::$testFiles['file1'], '');
452438
Utility::fileWrite(self::$testFiles['file2'], '');
453439

454-
try {
455-
$this->expectException(\InvalidArgumentException::class);
456-
$count = Utility::directorySize('/this/should/not/exist');
457-
} finally {
458-
//
459-
}
440+
$this->expectException(\InvalidArgumentException::class);
441+
$count = Utility::directorySize('/this/should/not/exist');
460442
}
461443

462444
/**
@@ -482,12 +464,8 @@ public function testDirectoryList(): void
482464
Utility::fileWrite(self::$testFiles['file1'], '');
483465
Utility::fileWrite(self::$testFiles['file2'], '');
484466

485-
try {
486-
$this->expectException(\InvalidArgumentException::class);
487-
$count = Utility::directoryList('/this/should/not/exist');
488-
} finally {
489-
//
490-
}
467+
$this->expectException(\InvalidArgumentException::class);
468+
$count = Utility::directoryList('/this/should/not/exist');
491469
}
492470

493471
/**
@@ -520,12 +498,8 @@ public function testFileRead(): void
520498

521499
Utility::fileWrite(self::$testFiles['file1'], '');
522500

523-
try {
524-
$this->expectException(\InvalidArgumentException::class);
525-
$read = Utility::fileRead(self::$testFiles['file1'] . '.php');
526-
} finally {
527-
//
528-
}
501+
$this->expectException(\InvalidArgumentException::class);
502+
$read = Utility::fileRead(self::$testFiles['file1'] . '.php');
529503
}
530504

531505
/**
@@ -537,12 +511,8 @@ public function testFileWrite(): void
537511

538512
Utility::fileWrite(self::$testFiles['file1'], '');
539513

540-
try {
541-
$this->expectException(\InvalidArgumentException::class);
542-
$read = Utility::fileWrite(self::$testFiles['file1'] . '.php');
543-
} finally {
544-
//
545-
}
514+
$this->expectException(\InvalidArgumentException::class);
515+
$read = Utility::fileWrite(self::$testFiles['file1'] . '.php');
546516
}
547517

548518
/**
@@ -723,16 +693,9 @@ public function testTimeDifference(): void
723693

724694
$this->assertEquals('1 second(s) old', Utility::timeDifference(\time() - 1, 0, ''));
725695

726-
try {
727-
$this->expectException(\InvalidArgumentException::class);
728-
$time = Utility::timeDifference(\time() - 30, 0, 'INVALID');
729-
730-
$this->expectException(\InvalidArgumentException::class);
731-
$time = Utility::timeDifference(-8400, 0);
732-
} finally {
733-
//
734-
}
735-
696+
$this->expectException(\InvalidArgumentException::class);
697+
$time = Utility::timeDifference(\time() - 30, 0, 'INVALID');
698+
$time = Utility::timeDifference(-8400, 0);
736699
}
737700

738701
/**
@@ -803,12 +766,8 @@ public function testObscureEmail(): void
803766
Utility::obscureEmail('[email protected]')
804767
);
805768

806-
try {
807-
$this->expectException(\InvalidArgumentException::class);
808-
$email = Utility::obscureEmail('thisisnotvalid&!--');
809-
} finally {
810-
//
811-
}
769+
$this->expectException(\InvalidArgumentException::class);
770+
$email = Utility::obscureEmail('thisisnotvalid&!--');
812771
}
813772

814773
/**

0 commit comments

Comments
 (0)