engineapi: Add request ascending order check (#13698)

somnathb1 · web-flow · commit 3c29eccd58fa · 2025-02-06T13:12:09.000+04:00
As per updated specs, this check should preemptively return -32602 See https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#engine_newpayloadv4
diff --git a/turbo/engineapi/engine_server.go b/turbo/engineapi/engine_server.go
@@ -220,10 +220,12 @@ func (s *EngineServer) newPayload(ctx context.Context, req *engine_types.Executi
 	}
 	if version >= clparams.ElectraVersion {
 		requests = make(types.FlatRequests, 0)
+		lastReqType := -1
 		for i, r := range executionRequests {
-			if len(r) <= 1 {
+			if len(r) <= 1 || lastReqType >= 0 && int(r[0]) <= lastReqType {
 				return nil, &rpc.InvalidParamsError{Message: fmt.Sprintf("Invalid Request at index %d", i)}
 			}
+			lastReqType = int(r[0])
 			requests = append(requests, types.FlatRequest{Type: r[0], RequestData: r[1:]})
 		}
 		rh := requests.Hash()

Original file line number	Diff line number	Diff line change
`@@ -220,10 +220,12 @@ func (s EngineServer) newPayload(ctx context.Context, req engine_types.Executi`
`220`	`220`	`}`
`221`	`221`	`if version >= clparams.ElectraVersion {`
`222`	`222`	`requests = make(types.FlatRequests, 0)`
	`223`	`+ lastReqType := -1`
`223`	`224`	`for i, r := range executionRequests {`
`224`		`- if len(r) <= 1 {`
	`225`	`+ if len(r) <= 1 \|\| lastReqType >= 0 && int(r[0]) <= lastReqType {`
`225`	`226`	`return nil, &rpc.InvalidParamsError{Message: fmt.Sprintf("Invalid Request at index %d", i)}`
`226`	`227`	`}`
	`228`	`+ lastReqType = int(r[0])`
`227`	`229`	`requests = append(requests, types.FlatRequest{Type: r[0], RequestData: r[1:]})`
`228`	`230`	`}`
`229`	`231`	`rh := requests.Hash()`