Skip to content

Commit 54f74be

Browse files
Fix guard clauses
1 parent 1581a4b commit 54f74be

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

lib/promenade/pitchfork/stats.rb

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ def initialize
2727

2828
raindrops_stats = Raindrops::Stats.new
2929

30-
@active_workers = raindrops_stats.active_workers
31-
@queued_requests = raindrops_stats.queued_requests
30+
@active_workers = raindrops_stats.active_workers || 0
31+
@queued_requests = raindrops_stats.queued_requests || 0
3232
end
3333

3434
def instrument
@@ -47,16 +47,13 @@ def self.instrument
4747
attr_reader :workers_count, :live_workers_count, :active_workers, :queued_requests
4848

4949
def capacity
50-
return 0 if live_workers_count.nil? || active_workers.nil?
51-
return 0 if live_workers_count&.zero?
52-
return 0 if active_workers&.zero?
50+
return 0 if live_workers_count.nil? || live_workers_count.zero?
5351

5452
live_workers_count - active_workers
5553
end
5654

5755
def busy_percent
58-
return 100 if live_workers_count.zero?
59-
return 100 if active_workers&.zero?
56+
return 0 if live_workers_count.zero?
6057

6158
(active_workers.to_f / live_workers_count) * 100
6259
end

0 commit comments

Comments
 (0)