Fix deprication warnings thrown by the testsuite

errm · Feb 9, 2024 · 99ceabb · 99ceabb
1 parent 698d144
commit 99ceabb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/spec/dummy/config/environments/test.rb b/spec/dummy/config/environments/test.rb
@@ -23,7 +23,7 @@
   config.cache_store = :null_store
 
   # Raise exceptions instead of rendering exception templates.
-  config.action_dispatch.show_exceptions = false
+  config.action_dispatch.show_exceptions = :none
 
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false

diff --git a/spec/integration/show_exceptions_middleware_spec.rb b/spec/integration/show_exceptions_middleware_spec.rb
@@ -59,7 +59,7 @@
     def enable_show_exceptions
       self.initial_env_config = Rails.application.env_config
       Rails.application.env_config.merge!(
-        "action_dispatch.show_exceptions" => true,
+        "action_dispatch.show_exceptions" => :all,
         "action_dispatch.show_detailed_exceptions" => false,
         "consider_all_requests_local" => false,
       )

diff --git a/spec/promenade/client/rack/exception_handler_spec.rb b/spec/promenade/client/rack/exception_handler_spec.rb
@@ -100,11 +100,11 @@
       exception_counter = Prometheus::Client.registry.get(:http_exceptions_total)
       request_duration_seconds = 1.0
 
-      expect(Proc.new do
+      expect do
         Promenade::Client::Rack::ExceptionHandler.call(exception,
           env_hash,
           request_duration_seconds)
-      end).to raise_error(exception_klass)
+      end.to raise_error(exception_klass)
     end
   end