Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Cache::primary_store to load a non-empty store #27

Open
eschkufz opened this issue Feb 11, 2017 · 1 comment
Open

Using Cache::primary_store to load a non-empty store #27

eschkufz opened this issue Feb 11, 2017 · 1 comment

Comments

@eschkufz
Copy link
Owner

I'm fine with leaving it as undefined behavior if you modify the primary store once you've passed ownership of it to a cache. But when you do this, the cache should at the very least reset its policies (probably clear everything and then touch everything in the new primary store).

@eschkufz
Copy link
Owner Author

(Note that you don't have this same problem with AdapterStore since it doesn't maintain any state relative to the underlying store. This is a Cache-only problem, despite the similar implementation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant