fix(no-callback-literal): report object, array, and template literals (#552)

Author: baevm

lib/rules/no-callback-literal.js

@@ -59,6 +59,10 @@ function couldBeError(node) {
             return true // possibly an error object.
         case "Literal":
             return node.value == null
+        case "ArrayExpression":
+        case "ObjectExpression":
+        case "TemplateLiteral":
+            return false
         case "AssignmentExpression":
             return couldBeError(node.right)
 

tests/lib/rules/no-callback-literal.js

@@ -105,6 +105,33 @@ ruleTester.run("no-callback-literal", rule, {
                 },
             ],
         },
+        {
+            code: "cb({ a: 1 })",
+            errors: [
+                {
+                    message:
+                        "Unexpected literal in error position of callback.",
+                },
+            ],
+        },
+        {
+            code: "cb([])",
+            errors: [
+                {
+                    message:
+                        "Unexpected literal in error position of callback.",
+                },
+            ],
+        },
+        {
+            code: "cb(`message ${value}`)",
+            errors: [
+                {
+                    message:
+                        "Unexpected literal in error position of callback.",
+                },
+            ],
+        },
         {
             code: "callback((a, 1), data)",
             errors: [