Skip to content

Commit 435f59f

Browse files
committed
ESP8266WebServer code review, fix indentation, add keywords
1 parent 9fd686b commit 435f59f

File tree

4 files changed

+301
-288
lines changed

4 files changed

+301
-288
lines changed

Diff for: libraries/ESP8266WebServer/examples/HelloServer/HelloServer.ino

+8-7
Original file line numberDiff line numberDiff line change
@@ -9,24 +9,23 @@ MDNSResponder mdns;
99

1010
ESP8266WebServer server(80);
1111

12-
void handle_root() {
12+
void handleRoot() {
1313
server.send(200, "text/plain", "hello from esp8266!");
1414
}
1515

16-
bool handle_not_found(){
16+
void handleNotFound(){
1717
String message = "URI: ";
1818
message += server.uri();
1919
message += "\nMethod: ";
2020
message += (server.method() == HTTP_GET)?"GET":"POST";
21+
message += "\nNot Found!\n\n";
2122
message += "\nArguments: ";
2223
message += server.args();
2324
message += "\n";
2425
for (uint8_t i=0; i<server.args(); i++){
2526
message += " " + server.argName(i) + ": " + server.arg(i) + "\n";
2627
}
27-
message += "\nNotFound!";
2828
server.send(404, "text/plain", message);
29-
return true;
3029
}
3130

3231
void setup(void){
@@ -45,15 +44,17 @@ void setup(void){
4544
Serial.print("IP address: ");
4645
Serial.println(WiFi.localIP());
4746

48-
if (mdns.begin("esp8266", WiFi.localIP())) Serial.println("MDNS responder started");
47+
if (mdns.begin("esp8266", WiFi.localIP())) {
48+
Serial.println("MDNS responder started");
49+
}
4950

50-
server.on("/", handle_root);
51+
server.on("/", handleRoot);
5152

5253
server.on("/inline", [](){
5354
server.send(200, "text/plain", "this works as well");
5455
});
5556

56-
server.onNotFound(handle_not_found);
57+
server.onNotFound(handleNotFound);
5758

5859
server.begin();
5960
Serial.println("HTTP server started");

Diff for: libraries/ESP8266WebServer/keywords.txt

+4
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ method KEYWORD2
2121
client KEYWORD2
2222
send KEYWORD2
2323
arg KEYWORD2
24+
argName KEYWORD2
25+
args KEYWORD2
26+
hasArg KEYWORD2
27+
onNotFound KEYWORD2
2428

2529
#######################################
2630
# Constants (LITERAL1)

0 commit comments

Comments
 (0)